Transform zip zone in entity #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove left_joins which generates problem when is processed by `merge` method - match the zip code as state and country
Pass nil as third params to with_member_ids to prevent the search for zip code.
DanielePalombo
force-pushed
the
nebulab/zip-code-as-entity
branch
from
18a002a to
7969cdd
Compare
Match cannot call for_address(address).first because for_address does not return the zone members in order zip_code, state, country.
DanielePalombo
force-pushed
the
nebulab/zip-code-as-entity
branch
from
a8f31dd to
e28ee70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transform zip zone in entity