This repository has been archived by the owner on Oct 4, 2023. It is now read-only.
Use module_eval to override link_to_cart in Solidus Demo #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsmendoza
force-pushed
the
gsmendoza/eng-283-use-class_eval-to-override-link_to_cart
branch
from
766b506 to
4f74958
Compare
Goal ---- As a Solidus Demo contributor I would like to use `module_eval` to override `link_to_cart` So that we can ensure that the `Spree::BaseHelper` engine module is reopened by Solidus Demo, which according to https://guides.rubyonrails.org/engines.html#improving-engine-functionality, is necessary for overriding the engine module. Basis ----- From https://guides.rubyonrails.org/engines.html#improving-engine-functionality: > It is very important that the override reopens the class or module. Using the class or module keywords would define them if they were not already in memory, which would be incorrect because the definition lives in the engine. Using `class_eval` as shown above ensures you are reopening.
gsmendoza
changed the title
gsmendoza
force-pushed
the
gsmendoza/eng-283-use-class_eval-to-override-link_to_cart
branch
from
4f74958 to
7d8d489
Compare
|
Why not create a new helper for the application that contains a helper function with the same name instead? I think |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
As a Solidus Demo contributor
I would like to use
module_evalto overridelink_to_cartSo that we can ensure that the
Spree::BaseHelperengine module isreopened by Solidus Demo, which according to
https://guides.rubyonrails.org/engines.html#improving-engine-functionality,
is necessary for overriding the engine module.
Basis
From
https://guides.rubyonrails.org/engines.html#improving-engine-functionality:
Demo
https://www.loom.com/share/f1193e1d0583435e83db43f9f1a27da6