Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure "sqlite3" is supported in addition to "sqlite" for testing #4718

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Ensure "sqlite3" is supported in addition to "sqlite" for testing #4718

wants to merge 1 commit into from

Conversation

elia
Copy link
Member

@elia elia commented Nov 15, 2022 •
edited
Loading

Summary

The current name is legacy and rails now uses "sqlite3", starting to move in that direction simplifies some setups (e.g. sandbox creation inside extensions).

Matching PR in the extensions ORB: solidusio/circleci-orbs-extensions#66

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

  • I have written a thorough PR description.
  • I have kept my commits small and atomic.
  • I have used clear, explanatory commit messages.

The following are not always needed (cross them out if they are not):

  • I have added automated tests to cover my changes.
  • I have attached screenshots to demo visual changes.
  • I have opened a PR to update the guides.
  • I have updated the README to account for my changes.

@github-actions github-actions bot added the changelog:solidus_core Changes to the solidus_core gem label Nov 15, 2022
@elia elia force-pushed the elia/standard-sqlite-db-name branch 3 times, most recently from ee2a10e to 1e44802 Compare November 15, 2022 11:08
@waiting-for-dev waiting-for-dev added the type:enhancement Proposed or newly added feature label Nov 17, 2022
@elia elia mentioned this pull request Nov 25, 2022
Merged
@elia elia force-pushed the elia/standard-sqlite-db-name branch from 1e44802 to 8185b11 Compare April 19, 2023 21:30
@github-actions github-actions bot added changelog:repository Changes to the repository not within any gem changelog:solidus Changes to the solidus meta-gem labels Apr 19, 2023
@elia elia force-pushed the elia/standard-sqlite-db-name branch 2 times, most recently from 3f537cb to 3e9a614 Compare April 19, 2023 21:59
@elia
Ensure "sqlite3" is supported in addition to "sqlite" for testing
f570a78 
The current name is legacy and rails now uses "sqlite3", starting to
move in that direction simplifies some setups (e.g. sandbox creation
inside extensions).

Also cleaned up the database.yml template which was barely readable.
@elia elia force-pushed the elia/standard-sqlite-db-name branch from 3e9a614 to f570a78 Compare April 19, 2023 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
changelog:repository Changes to the repository not within any gem changelog:solidus_core Changes to the solidus_core gem changelog:solidus Changes to the solidus meta-gem type:enhancement Proposed or newly added feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elia @waiting-for-dev