Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add back PayPal as a payment method for the starter frontend #4743

Merged
merged 2 commits into from
Dec 13, 2022
Merged

Add back PayPal as a payment method for the starter frontend #4743

merged 2 commits into from
Dec 13, 2022

Conversation

elia
Copy link
Member

@elia elia commented Nov 25, 2022 •
edited
Loading

Summary

Restore paypal as a payment method option for when SSF is used as a frontend. Given the SSF has no versioning that we can use to connect it to the right version via dependencies we need to store the knowledge of which is the right version inside the installer itself. The installer will use v0.x for the classic frontend and v1.x for the starter frontend.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

  • I have written a thorough PR description.
  • I have kept my commits small and atomic.
  • I have used clear, explanatory commit messages.

The following are not always needed (cross them out if they are not):

  • I have added automated tests to cover my changes.
  • I have attached screenshots to demo visual changes.
  • I have opened a PR to update the guides.
  • I have updated the README to account for my changes.

@github-actions github-actions bot added the changelog:solidus_core Changes to the solidus_core gem label Nov 25, 2022
@elia elia self-assigned this Nov 25, 2022
@elia elia mentioned this pull request Nov 28, 2022
Closed
@waiting-for-dev waiting-for-dev added the type:enhancement Proposed or newly added feature label Nov 28, 2022
@elia
Don't test twice the alternative frontend option names
60b0ac3 
Those are already covered in the installer generator spec.
@elia elia force-pushed the elia/paypal-ssf-support branch from 6ecd31c to 561a47d Compare December 5, 2022 14:43
@elia elia force-pushed the elia/paypal-ssf-support branch from 561a47d to d40a01c Compare December 5, 2022 22:26
@elia elia marked this pull request as ready for review December 6, 2022 14:49
@elia elia requested a review from a team as a code owner December 6, 2022 14:49
waiting-for-dev
waiting-for-dev approved these changes Dec 7, 2022
View reviewed changes
Copy link
Contributor

@waiting-for-dev waiting-for-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @elia! I left two questions. I think there's an issue when not installing a payment method. Non-blocking as the issue was already there.

core/lib/generators/solidus/install/install_generator.rb Show resolved Hide resolved
core/lib/generators/solidus/install/app_templates/payment_method/paypal.rb Show resolved Hide resolved
@elia elia requested a review from a team December 12, 2022 12:35
@waiting-for-dev waiting-for-dev merged commit 553c26e into solidusio:master Dec 13, 2022
@waiting-for-dev waiting-for-dev deleted the elia/paypal-ssf-support branch December 13, 2022 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waiting-for-dev waiting-for-dev waiting-for-dev approved these changes

@spaghetticode spaghetticode spaghetticode approved these changes

Assignees

@elia elia

Labels
changelog:solidus_core Changes to the solidus_core gem type:enhancement Proposed or newly added feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Conditionally pick a different paypal version during the installation, based on the frontend selected
3 participants
@elia @waiting-for-dev @spaghetticode