Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v4.2] Use bundler gem tasks instead of gem_release #5414

Merged
merged 1 commit into from
Oct 4, 2023
Merged

[v4.2] Use bundler gem tasks instead of gem_release #5414

merged 1 commit into from
Oct 4, 2023

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Oct 4, 2023

Backport

This will backport the following commits from main to v4.2:

Questions ?

Please refer to the Backport tool documentation

@elia
Use bundler gem tasks instead of gem_release
1820e6a 
Now that we also have a solidus_admin that follows a different release
track we need more control over what gems are released. `gem_release`
has no such control available and simply has a configuration for
recursing. Also all the features of `gem_relerase` regarding version
numbers manipulation are no longer relevant as it all happens within
GitHub actions using dev_tools.

Bundler gem tasks are now the standard for all our extensions and are
a simpler, already available, tool that can be leveraged here as well.

(cherry picked from commit ccf0eaa)
@github-actions github-actions bot requested a review from a team as a code owner October 4, 2023 08:55
@github-actions github-actions bot added changelog:repository Changes to the repository not within any gem changelog:skip Changes that we don't want to be listed in the Changelog changelog:solidus_api Changes to the solidus_api gem changelog:solidus_backend Changes to the solidus_backend gem changelog:solidus_core Changes to the solidus_core gem changelog:solidus_sample Changes to the solidus_sample gem labels Oct 4, 2023
@github-actions github-actions bot mentioned this pull request Oct 4, 2023
Merged
3 tasks
@elia elia merged commit 208d97d into v4.2 Oct 4, 2023
@elia elia deleted the backport/v4.2/pr-5413 branch October 4, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@elia elia

Labels
changelog:repository Changes to the repository not within any gem changelog:skip Changes that we don't want to be listed in the Changelog changelog:solidus_api Changes to the solidus_api gem changelog:solidus_backend Changes to the solidus_backend gem changelog:solidus_core Changes to the solidus_core gem changelog:solidus_sample Changes to the solidus_sample gem
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@elia