Skip ActionCable for dummy apps
#5420
Conversation
github-actions
bot
added
the
changelog:solidus_core
|
Rails 7.1 came out. |
True dat. Not sure why the installer spec fails if this happens 🤔 |
|
I think it's because the installer specs simulate the install process, which uses Rails at the latest available version. We need to investigate, cc @elia @rainerdema @stefano-sarioli |
That's correct, I'm working on fixing the CircleCI script, meanwhile I think we can merge this, knowing the failure is a false negative 👍 |
|
#5421 has been merged, rebasing should fix the CI |
We don't really use ActionCable for anything as far as I know. Having it makes installing Turbo/Stimulus in extensions harder. The installer for Turbo will look for a Gemfile in `Rails.root`, which is not there in case of the dummy app, and fail. If, however, `config/cable.yml` can't be found, the Turbo installer succeeds with a message that Turbo is installed, just without the broadcasting feature (which is alright for most apps I believe).
mamhoff
force-pushed
the
skip-action-cable-in-dummy-apps
branch
from
e83bb5a to
3f8ad82
Compare
Codecov Report
@@ Coverage Diff @@
## main #5420 +/- ##
==========================================
- Coverage 88.86% 88.85% -0.01%
==========================================
Files 607 607
Lines 14747 14748 +1
==========================================
Hits 13105 13105
- Misses 1642 1643 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Yes, this does need to be backported to solidus 3.4 - 4.2. I can't add the backport labels due to lack of permission. Can anyone? |
kennyadsl
added
backport-v3.4
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Summary
We don't really use ActionCable for anything as far as I know. Having it makes installing Turbo/Stimulus in extensions harder.
The installer for Turbo will look for a Gemfile in
Rails.root, which is not there in case of the dummy app, and fail. If, however,config/cable.ymlcan't be found, the Turbo installer succeeds with a message that Turbo is installed, just without the broadcasting feature (which is alright for most apps I believe).Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: