Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop autoprefixer-rails from dependencies #5521

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

elia
Copy link
Member

@elia elia commented Nov 28, 2023

Summary

No need to force it on the whole application asset pipeline in 2023, and it's easy to add it back locally if really needed.

Also gets rid of that annoying message about color-adjust:

autoprefixer: /Users/elia/Code/Nebulab/solidus_stripe/dummy-app/vendor/assets/stylesheets/spree/backend/all.css:1992:5: Replace color-adjust to print-color-adjust. The color-adjust shorthand is currently deprecated.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

No need to force it on the whole application asset pipeline in 2023,
and it's easy to add it back locally if really needed.
@elia elia self-assigned this Nov 28, 2023
@github-actions github-actions bot added the changelog:solidus_backend Changes to the solidus_backend gem label Nov 28, 2023
@elia elia marked this pull request as ready for review November 29, 2023 09:22
@elia elia requested a review from a team as a code owner November 29, 2023 09:22
@elia elia requested a review from rainerdema November 29, 2023 09:22
@elia elia merged commit 9609689 into main Nov 29, 2023
8 checks passed
@elia elia deleted the elia/drop-autoprefixer-from-backend branch November 29, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:solidus_backend Changes to the solidus_backend gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants