Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[admin] Extract common admin resources patterns to a helper #5534

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

elia
Copy link
Member

@elia elia commented Dec 4, 2023

Summary

Compact the routes file and ensure we can apply widespread patterns to all admin resources

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@elia elia requested a review from rainerdema December 4, 2023 14:20
@elia elia self-assigned this Dec 4, 2023
@elia elia requested a review from a team as a code owner December 4, 2023 14:20
@elia elia force-pushed the elia/admin/admin_resources branch from 6142651 to 87fe0d3 Compare December 4, 2023 14:25
@elia elia force-pushed the elia/admin/admin_resources branch from 87fe0d3 to b90b31b Compare December 4, 2023 15:16
@elia elia changed the title [admin] Extract common admin resources patters to a helper [admin] Extract common admin resources patterns to a helper Dec 4, 2023
@elia elia merged commit 8a41475 into main Dec 4, 2023
2 checks passed
@elia elia deleted the elia/admin/admin_resources branch December 4, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants