Format date with #to_fs #5863
Merged
Format date with #to_fs #5863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The #to_s(format) method was deprecated and removed from Rails 7.1. This is causing `ActionView::Template::Error wrong number of arguments (given 1, expected 0)` when a tax rate with an expiration date is displayed.
github-actions
bot
added
the
changelog:solidus_backend
|
Hey @alepore 👋🏻 |
tvdeyen
approved these changes
Oct 3, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5863 +/- ##
=======================================
Coverage 89.23% 89.23%
=======================================
Files 752 752
Lines 17510 17510
=======================================
Hits 15625 15625
Misses 1885 1885
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
adammathys
approved these changes
Oct 3, 2024
jarednorman
approved these changes
Oct 3, 2024
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
|
Thanks @alepore ! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Hello!!!
The
#to_s(format)method was deprecated and removed from Rails 7.0, the correct method is now#to_fs.This is causing
ActionView::Template::Error wrong number of arguments (given 1, expected 0)when a tax rate with an expiration date is displayed.
The test was passing just because an expiration date was not set.
Checklist