Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Remove spacing at top of OrderShipping#ship method #5954

Merged
merged 1 commit into from
Nov 30, 2024

Conversation

adammathys
Copy link
Member

Summary

Newest version of Rubocop wants us to remove extra spacing at the top of method bodies.

Checklist

@adammathys adammathys requested a review from a team as a code owner November 27, 2024 23:36
@github-actions github-actions bot added the changelog:solidus_core Changes to the solidus_core gem label Nov 27, 2024
Newest version of Rubocop wants us to remove extra spacing at the top of
method bodies.
@adammathys adammathys force-pushed the fix/new-rubocop-rules branch from b714451 to 6d44a13 Compare November 28, 2024 22:16
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.81%. Comparing base (c560453) to head (6d44a13).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5954      +/-   ##
==========================================
- Coverage   89.45%   87.81%   -1.65%     
==========================================
  Files         782      476     -306     
  Lines       17997    11656    -6341     
==========================================
- Hits        16100    10236    -5864     
+ Misses       1897     1420     -477     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tvdeyen tvdeyen merged commit 68c4b1a into solidusio:main Nov 30, 2024
15 of 16 checks passed
@mamhoff
Copy link
Contributor

mamhoff commented Dec 2, 2024

backport to 4.0 - 4.4

Copy link

github-actions bot commented Dec 2, 2024

💔 Some backports could not be created

Status Branch Result
v4.0
v4.1
v4.2
v4.3 An unhandled error occurred. Please see the logs for details
v4.4

Manual backport

To create the backport manually run:

backport --pr 5954

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Copy link

github-actions bot commented Dec 2, 2024

💔 Some backports could not be created

Status Branch Result
v4.0 An unhandled error occurred. Please see the logs for details
v4.1
v4.2
v4.3
v4.4

Manual backport

To create the backport manually run:

backport --pr 5954

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Copy link

github-actions bot commented Dec 2, 2024

💔 Some backports could not be created

Status Branch Result
v4.0
v4.1 An unhandled error occurred. Please see the logs for details
v4.2
v4.3
v4.4

Manual backport

To create the backport manually run:

backport --pr 5954

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Copy link

github-actions bot commented Dec 2, 2024

💚 All backports created successfully

Status Branch Result
v4.0
v4.1
v4.2
v4.3
v4.4

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Copy link

github-actions bot commented Dec 2, 2024

💚 All backports created successfully

Status Branch Result
v4.0
v4.1
v4.2
v4.3
v4.4

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v4.0 Backport this pull-request to v4.0 backport-v4.1 Backport this pull-request to v4.1 backport-v4.2 Backport this pull-request to v4.2 backport-v4.3 Backport this pull-request to v4.3 backport-v4.4 Backport this pull-request to v4.4 changelog:solidus_core Changes to the solidus_core gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants