Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to set Rails deprecations behavior during tests #6000

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Dec 4, 2024

Set the desired deprecation behavior via RAILS_DEPRECATIONS_BEHAVIOR ENV var. Defaults to :stderr. Possible values are

  • raise - Raise ActiveSupport::DeprecationException.
  • stderr - Log all deprecation warnings to $stderr.
  • log - Log all deprecation warnings to Rails.logger.
  • notify - Use ActiveSupport::Notifications to notify deprecation.rails.
  • report - Use ActiveSupport::ErrorReporter to report deprecations.
  • silence - Do nothing

Refs: https://api.rubyonrails.org/classes/ActiveSupport/Deprecation/Behavior.html

@tvdeyen tvdeyen requested a review from a team as a code owner December 4, 2024 14:24
@github-actions github-actions bot added the changelog:solidus_core Changes to the solidus_core gem label Dec 4, 2024
@tvdeyen
Copy link
Member Author

tvdeyen commented Dec 4, 2024

I plan to use this while working on the Rails 8 update

Set the desired deprecation behavior via RAILS_DEPRECATIONS_BEHAVIOR
ENV var. Defaults to :stderr. Possible values are

  - raise - Raise ActiveSupport::DeprecationException.
  - stderr - Log all deprecation warnings to $stderr.
  - log - Log all deprecation warnings to Rails.logger.
  - notify - Use ActiveSupport::Notifications to notify deprecation.rails.
  - report - Use ActiveSupport::ErrorReporter to report deprecations.
  - silence - Do nothing

Refs: https://api.rubyonrails.org/classes/ActiveSupport/Deprecation/Behavior.html
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.81%. Comparing base (082d3b8) to head (3510b9b).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6000   +/-   ##
=======================================
  Coverage   87.81%   87.81%           
=======================================
  Files         476      476           
  Lines       11658    11658           
=======================================
  Hits        10238    10238           
  Misses       1420     1420           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mamhoff mamhoff force-pushed the allow-raise-deprecations branch from 5afadd7 to 3510b9b Compare December 4, 2024 14:43
@tvdeyen tvdeyen merged commit 18fba3e into solidusio:main Dec 5, 2024
16 checks passed
@tvdeyen tvdeyen deleted the allow-raise-deprecations branch December 5, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:solidus_core Changes to the solidus_core gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants