Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v4.4] tests: Give dialogs a little more time to open #6012

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Dec 5, 2024

Backport

This will backport the following commits from main to v4.4:

Questions ?

Please refer to the Backport tool documentation

The default time of 2 seconds is not enough sometimes.
Give it 3 more seconds to wait until Capybara raises an
error.

(cherry picked from commit a30d802)
@github-actions github-actions bot requested a review from a team as a code owner December 5, 2024 12:54
@github-actions github-actions bot added the changelog:repository Changes to the repository not within any gem label Dec 5, 2024
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.81%. Comparing base (da7a72d) to head (a4677fa).
Report is 2 commits behind head on v4.4.

Additional details and impacted files
@@            Coverage Diff             @@
##             v4.4    #6012      +/-   ##
==========================================
- Coverage   89.45%   87.81%   -1.64%     
==========================================
  Files         782      476     -306     
  Lines       17993    11658    -6335     
==========================================
- Hits        16096    10238    -5858     
+ Misses       1897     1420     -477     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tvdeyen tvdeyen merged commit bfdf4bb into v4.4 Dec 5, 2024
13 of 14 checks passed
@tvdeyen tvdeyen deleted the backport/v4.4/pr-6010 branch December 5, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:repository Changes to the repository not within any gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants