Use flickwerk-style patches #254
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves the patches in this gem from `lib/decorators/` to `lib/patches`, allowing Flickwerk to take over the patching.
This names the patches such that they do not live in the Spree namespace. It also fixes a Rubocop offense.
|
@solidusio/core-team can we get a second review here? |
|
Is this on hold now that we reverted the flickwerk PR in solidus_support? |
|
Let's keep it open. I'm fixing the issues that led to reverting Flickwerk support in |
This does what solidus_support would do if Flickwerk support was built into that.
This way, we don't need to load ApplicationController in a config.to_prepare block either.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the patches in this gem from
lib/decorators/tolib/patches, allowing Flickwerk to take over the patching.