Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency to test generators #155

Merged
merged 1 commit into from
Apr 30, 2021

Conversation

waiting-for-dev
Copy link
Contributor

Description

The dependency that was in use in order to help testing generators have
not been updated since 2017 (ATTOW).

There's an alternative library that seems better maintained
(https://github.com/alexrothenberg/ammeter).

However, as we already have the dummy application our setup is very
simple and we don't need any external dependency.

This is preliminary work to implement what is described in #153 (comment).

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@waiting-for-dev can you please rebase?

The dependency that was in use in order to help testing generators have
not been updated since 2017 (ATTOW).

There's an alternative library that seems better maintained
(https://github.com/alexrothenberg/ammeter).

However, as we already have the dummy application our setup is very
simple and we don't need any external dependency.
@waiting-for-dev waiting-for-dev force-pushed the waiting-for-dev/generator_test_dependency branch from 6049752 to a282ffb Compare April 30, 2021 03:32
@waiting-for-dev
Copy link
Contributor Author

Rebase done @kennyadsl 👍

@kennyadsl kennyadsl merged commit 1995e58 into master Apr 30, 2021
@kennyadsl kennyadsl deleted the waiting-for-dev/generator_test_dependency branch April 30, 2021 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants