Fix and update sandbox script #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Goal ---- As a solidus_starter_frontend contributor I want the gem's sandbox script to generate the app with the solidus_starter_frontend gem as an engine So that the app would pick up changes I make to the app code Background ---------- Currently, the sandbox script both loads the gem and runs its generator. We want it to only the load the gem. Previous implementations ------------------------ * [Document how to run the extension as an engine in a Rails app](a4600e2) - This commit documents how to install solidus_starter_frontend as an engine. * Fix sandbox script #166 - This PR fixed the script to run `solidus_starter_frontend` as a generator instead of as a gem. Relevant links -------------- #167 (comment) - discussion on having two strategies for generating the sandbox app: one with the Starter FE running as an engine and other where Starter FE is generated into the app. Implementation -------------- * Point solidus gems in sandbox Gemfile to those in solidus_starter_frontend's Gemfile. * Fix: Install solidus using `solidus:install` instead of `spree:install`. * Fix: Pass `--auto-run-migrations` instead of `--auto-accept` to `solidus:auth:install`. * Remove `solidus_starter_frontend` call. * Call `bundle exec rails g solidus_starter_frontend:install`.
gsmendoza
commented
Jul 20, 2021
| unbundled bundle exec rails generate solidus:auth:install --auto-accept | ||
| unbundled bundle exec rails generate ${extension_name}:install --auto-accept | ||
| unbundled bundle exec rails generate solidus:auth:install --auto-run-migrations | ||
| unbundled bundle exec rails g solidus_starter_frontend:install |
There was a problem hiding this comment.
An alternative to running the solidus_starter_frontend:install install command is to add the assets directly to app/views/spree/layouts/spree_application.html.erb and then strip them from the layout when running the generator. Let me know if you prefer this alternative.
There was a problem hiding this comment.
Not sure to get what you mean here, do you have an example?
There was a problem hiding this comment.
@kennyadsl I was easier to create a separate PR implementing that change :) Please see #170. Thanks!
There was a problem hiding this comment.
I'd just go with this PR's route for now.
kennyadsl
approved these changes
Jul 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
As a
solidus_starter_frontendcontributorI want the gem's sandbox script to generate the app with the
solidus_starter_frontend gemas an engineSo that the app would pick up changes I make to the app code
Background
Currently, the sandbox script both loads the gem and runs its generator. We want it to only the load the gem.
Previous implementations
solidus_starter_frontendas a generator instead of as a gem.Relevant links
#167 (comment) - discussion on having two strategies for generating the sandbox app: one with the Starter FE running as an engine and other where Starter FE is generated into the app.
Implementation
Point solidus gems in sandbox Gemfile to those in
solidus_starter_frontend's Gemfile.
Fix: Install solidus using
solidus:installinstead ofspree:install.Fix: Pass
--auto-run-migrationsinstead of--auto-accepttosolidus:auth:install.Remove
solidus_starter_frontendcall.Call
bundle exec rails g solidus_starter_frontend:install.Demo
https://www.loom.com/share/1c7c4ff55baf4d8d8404a77f8520ca30
Types of changes
Checklist: