Allow to skip frontend specs from extensions #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
added a commit
to tvdeyen/solidus
that referenced
this pull request
Dec 19, 2024
We want to be able to skip frontend specs from extension that run system specs against the generated dummy app. See solidusio/solidus_starter_frontend#400
3 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #400 +/- ##
==========================================
- Coverage 95.98% 95.95% -0.03%
==========================================
Files 207 207
Lines 4880 4870 -10
==========================================
- Hits 4684 4673 -11
- Misses 196 197 +1 ☔ View full report in Codecov by Sentry. |
When we test extensions with the new starter frontend we run this template to generate the dummy app. This template also installs all frontend specs. This leads to unnecessary long build times, flaky sepcs and simply wastes a lot of resources. Since the extension tests it's own behavior in the dummy app we simply must not duplicate every single spec we also test in this repo.
tvdeyen
force-pushed
the
allow-skip-specs
branch
from
1b7c413 to
65126b7
Compare
kennyadsl
approved these changes
Dec 19, 2024
jarednorman
approved these changes
Dec 19, 2024
|
@jarednorman can we create a clean slate and merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When we test extensions with the new starter frontend we run this template to generate the dummy app. This template also installs all frontend specs. This leads to unnecessary long build times, flaky sepcs and simply wastes a lot of resources.
Since the extension tests it's own behavior in the dummy app we simply must not duplicate every single spec we also test in this repo.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: