Improve timeout behavior #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of putting one timeout of 2 sec at the beginning of the check for the loop devices, use the already existing timeout implementation inside the loop and just increase the maximum timeout to 60 sec. This improves the overall behavior, because as soon as the loop devices are detected, the loop will be exited, but it also increases the maximum possible time to wait for the loop devices. This is helpful when being used on slower systems.
|
Waiting for approval from someone in the solo-io org to start testing. |
yuval-k
approved these changes
Mar 12, 2024
thomasmerx
added a commit
to thomasmerx/packer-plugin-arm-image
that referenced
this pull request
Jun 11, 2024
This fixes issue solo-io#162 and solo-io#165. I refactored the timeout handling, with solo-io#169 by increasing the existing timeout and removing the additional 2 sec sleep, because the 2 sec sleep was not working in all cases. Unfortunately, the increase alone is not sufficient, so I'm re-adding the 2 sec sleep again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of putting one timeout of 2 sec at the beginning of the check for the loop devices, use the already existing timeout implementation inside the loop and just increase the maximum timeout to 60 sec. This improves the overall behavior, because as soon as the loop devices are detected, the loop will be exited, but it also increases the maximum possible time to wait for the loop devices. This is helpful when being used on slower systems.