Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added age filter with range 1-20, 20-30, 30-40, 40-50, 50-60, 60-70 and 70 up #124

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

error-yatish
Copy link

This is a reference to #112

@vercel
Copy link

vercel bot commented Mar 27, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/someshkar/covid19india-network/e2s1f693n
✅ Preview: https://covid19india-network-git-fork-error-yatish-agefilteradded.someshkar.now.sh

@sibeshkar
Copy link
Collaborator

Thanks. Few changes :

  1. Make the Age node Icons bigger and increase edge length
  2. Add icon legend
  3. Modify age filter icon - maybe a clock icon will do

@error-yatish
Copy link
Author

@sibeshkar I have committed below changes

  1. Added Age node Icons and increased edge length
  2. Added icons to legend
  3. Changed age filter icon to Clock Icon

@sampathBlam
Copy link
Contributor

@error-yatish :
Great implementation. Just a couple of suggestions.

  1. All age groups seem to settle towards the centre of the cluster.

image

Can we move each group a bit away from each other so that each group is visible clearly? Like it happens for other filters? For eg, in case of state.

image

  1. Can we group all cases whose age is not known, into a separate group ?

@sibeshkar : Your suggestions here would be appreciated as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants