Fix

sonata-project · Oct 14, 2023 · 995912d · 995912d
1 parent 4ebfb9b
commit 995912d
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 15 deletions.
diff --git a/composer.json b/composer.json
@@ -37,7 +37,7 @@
         "phpunit/phpunit": "^9.5.13",
         "psalm/plugin-phpunit": "^0.18",
         "psalm/plugin-symfony": "^5.0",
-        "rector/rector": "^0.17",
+        "rector/rector": "^0.18",
         "symfony/browser-kit": "^5.4 || ^6.2",
         "symfony/cache": "^5.4 || ^6.2",
         "symfony/filesystem": "^5.4 || ^6.2",

diff --git a/tests/Functional/SmokeTest.php b/tests/Functional/SmokeTest.php
@@ -21,7 +21,7 @@
 final class SmokeTest extends WebTestCase
 {
     /**
-     * @dataProvider provideUrls
+     * @dataProvider provideSuccessfulResponsesCases
      */
     public function testSuccessfulResponses(string $url): void
     {
@@ -34,7 +34,7 @@ public function testSuccessfulResponses(string $url): void
     /**
      * @return iterable<array{string}>
      */
-    public function provideUrls(): iterable
+    public function provideSuccessfulResponsesCases(): iterable
     {
         yield 'index' => ['/audit'];
         yield 'view revision' => ['/audit/viewrev/1'];

diff --git a/tests/RelationTest.php b/tests/RelationTest.php
@@ -928,9 +928,9 @@ public function testOneToManyCollectionDeletedElements(): void
             $ids[] = $ownedElement->getId();
         }
 
-        static::assertTrue(\in_array($ownedOne->getId(), $ids, true));
-        static::assertTrue(\in_array($ownedThree->getId(), $ids, true));
-        static::assertTrue(\in_array($ownedFour->getId(), $ids, true));
+        static::assertContains($ownedOne->getId(), $ids);
+        static::assertContains($ownedThree->getId(), $ids);
+        static::assertContains($ownedFour->getId(), $ids);
     }
 
     public function testOneToOneEdgeCase(): void

diff --git a/tests/Utils/SimpleDiffTest.php b/tests/Utils/SimpleDiffTest.php
@@ -19,7 +19,7 @@
 final class SimpleDiffTest extends TestCase
 {
     /**
-     * @dataProvider dataDiff
+     * @dataProvider provideDiffCases
      */
     public function testDiff(string $old, string $new, string $output): void
     {
@@ -32,14 +32,12 @@ public function testDiff(string $old, string $new, string $output): void
     /**
      * @return iterable<array{string, string, string}>
      */
-    public static function dataDiff(): iterable
+    public static function provideDiffCases(): iterable
     {
-        return [
-            ['Foo', 'foo', '<del>Foo</del> <ins>foo</ins> '],
-            ['Foo Foo', 'Foo', 'Foo <del>Foo</del> '],
-            ['Foo', 'Foo Foo', 'Foo <ins>Foo</ins> '],
-            ['Foo Bar Baz', 'Foo Foo Foo', 'Foo <del>Bar Baz</del> <ins>Foo Foo</ins> '],
-            ['Foo Bar Baz', 'Foo Baz', 'Foo <del>Bar</del> Baz '],
-        ];
+        yield ['Foo', 'foo', '<del>Foo</del> <ins>foo</ins> '];
+        yield ['Foo Foo', 'Foo', 'Foo <del>Foo</del> '];
+        yield ['Foo', 'Foo Foo', 'Foo <ins>Foo</ins> '];
+        yield ['Foo Bar Baz', 'Foo Foo Foo', 'Foo <del>Bar Baz</del> <ins>Foo Foo</ins> '];
+        yield ['Foo Bar Baz', 'Foo Baz', 'Foo <del>Bar</del> Baz '];
     }
 }