Replace EntityManager type-hint with EntityManagerInterface #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmmanuelVella
force-pushed
the
entity-manager
branch
from
0496a7a to
04b75e5
Compare
EmmanuelVella
force-pushed
the
entity-manager
branch
from
04b75e5 to
013cf9b
Compare
dmaicher
reviewed
Apr 22, 2024
| * @return AuditReader | ||
| */ | ||
| public function createAuditReader(EntityManager $em) | ||
| public function createAuditReader(EntityManagerInterface $em) |
There was a problem hiding this comment.
This is a BC break however. Classes which are extending AuditReader and overwriting createAuditReader will break due to this change.
Hence we planned to do this in the next major release as the comment above suggested.
There was a problem hiding this comment.
Sure I understand. I'm closing the PR. Thank you !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
This PR fixes an issue when using an entity manager decorator (same as #149).
I am targeting this branch, because it's BC (EntityManagerInterface was introduced in doctrine orm
2.4, and version^2.7is required incomposer.json.Changelog