Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guess enum types #1768

Merged
merged 1 commit into from
Oct 22, 2023
Merged

Guess enum types #1768

merged 1 commit into from
Oct 22, 2023

Conversation

phansys
Copy link
Member

@phansys phansys commented Oct 21, 2023 •
edited
Loading

Subject

Guess enum types

I am targeting this branch, because this PR respects BC.

Changelog

### Added
- Guessing for enum types

@phansys phansys force-pushed the guess_enum branch 4 times, most recently from ea23016 to 7627e13 Compare October 21, 2023 12:50
@phansys phansys added the minor label Oct 21, 2023
@phansys phansys marked this pull request as ready for review October 21, 2023 12:54
@phansys phansys requested a review from a team October 21, 2023 12:55
@phansys phansys merged commit 584432a into sonata-project:4.x Oct 22, 2023
27 checks passed
@phansys phansys deleted the guess_enum branch October 22, 2023 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark left review comments

@VincentLanglet VincentLanglet VincentLanglet approved these changes

@dmaicher dmaicher dmaicher approved these changes

Assignees
No one assigned
Labels
minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@phansys @dmaicher @OskarStark @VincentLanglet