Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use existing secrets for imagePullSecrets #86

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions nxrm-ha/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,7 @@ After removing the deployment, ensure that the namespace is deleted and that Nex
The following table lists the configurable parameters of the Nexus chart and their default values.

| Parameter | Description | Default |
|-------------------------------------------------------------|----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|---------------------------------------------------------------------------------------------------------------------|
| ----------------------------------------------------------- | -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ------------------------------------------------------------------------------------------------------------------- |
| `namespaces.nexusNs.enabled` | Whether a namespace should be created for the Kubernetes resources needed Nexus Repository pod(s) | `true` |
| `namespaces.nexusNs.name` | The namespace into which Kubernetes resources for Nexus Repository are installed into, if set to `''` the release namespace is used | `nexusrepo` |
| `namespaces.cloudwatchNs.enabled` | Whether a namespace should be created to install the Kubernetes resources needed by fluentbit | `false` |
Expand Down Expand Up @@ -318,6 +318,7 @@ The following table lists the configurable parameters of the Nexus chart and the
| `statefulset.annotations` | Annotations to enhance statefulset configuration | {} |
| `statefulset.podAnnotations` | Pod annotations | {} |
| `statefulset.nodeSelector` | Node selectors | {} |
| `statefulset.tolerations` | Tolerations | [] |
| `statefulset.hostAliases` | Aliases for IPs in /etc/hosts | [] |
| `statefulset.postStart.command` | Command to run after starting the container | `null` |
| `statefulset.preStart.command` | Command to run before starting the container | `null` |
Expand All @@ -335,7 +336,7 @@ The following table lists the configurable parameters of the Nexus chart and the
| `statefulset.container.env.nexusDBPort` | The database port of the PostgreSQL database to use. | 5432 |
| `statefulset.container.env.install4jAddVmParams` | Xmx and Xms settings for JVM | -Xms2703m -Xmx2703m |
| `statefulset.container.env.jdbcUrlParams` | Additional parameters to append to the database url. Expected format is `"?foo=bar&baz=foo"` | null |
| `statefulset.container.additionalEnv` | Additional environment variables for the Nexus Repository container. You can also use this setting to override a default env variable by specifying the same key/name as the default env variable you wish override. Specify this as a block of name and value pairs (e.g., "<br/>additionalEnv:<br/>- name: foo<br/> value: bar<br/>- name: foo2<br/> value: bar2") | null |
| `statefulset.container.additionalEnv` | Additional environment variables for the Nexus Repository container. You can also use this setting to override a default env variable by specifying the same key/name as the default env variable you wish override. Specify this as a block of name and value pairs (e.g., "<br/>additionalEnv:<br/>- name: foo<br/> value: bar<br/>- name: foo2<br/> value: bar2") | null |
| `statefulset.requestLogContainer.image.repository` | Image registry URL for a container which tails Nexus Repository's request log | busybox |
| `statefulset.requestLogContainer.image.tag` | Image tag for a container which tails Nexus Repository's request log | 1.33.1 |
| `statefulset.requestLogContainer.resources.requests.cpu` | The minimum cpu the request log container can request | 0.1 |
Expand Down Expand Up @@ -369,7 +370,7 @@ The following table lists the configurable parameters of the Nexus chart and the
| `statefulset.readinessProbe.failureThreshold` | Number of attempts before failure | 6 |
| `statefulset.readinessProbe.timeoutSeconds` | Time in seconds after readiness probe times out | 1 |
| `statefulset.readinessProbe.path` | Path for ReadinessProbe | / |
| `statefulset.imagePullSecrets` | The pull secret for private image registries | `{}` |
| `statefulset.imagePullSecrets` | The pull secret for private image registries | `[]` |
| `ingress.enabled` | Whether or not to create the Ingress | false |
| `ingress.host` | Ingress host | `null` |
| `ingress.hostPath` | Path for ingress rules. | `/` |
Expand Down
18 changes: 0 additions & 18 deletions nxrm-ha/templates/image-pull-secret.yaml

This file was deleted.

4 changes: 2 additions & 2 deletions nxrm-ha/templates/statefulset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ spec:
{{- end }}
{{- if .Values.statefulset.imagePullSecrets }}
imagePullSecrets:
- name: {{ template "nexus.name" . }}-imagepullsecret
{{ toYaml . | nindent 8 }}
{{- end }}
containers:
- name: nxrm-app
Expand Down Expand Up @@ -275,7 +275,7 @@ spec:
persistentVolumeClaim:
claimName: {{ .Values.pvc.existingClaim }}
{{ end }}
{{- with .Values.tolerations }}
{{- with .Values.statefulset.tolerations }}
tolerations:
{{ toYaml . | nindent 8 }}
{{- end }}
Expand Down
Loading