RSC-1772: Vulnerability Indicator and Vulnerability Indicator Legend #1199
+1,377
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rability_indicator
…rability_indicator
…rability_indicator
…rability_indicator_legend
…rability_indicator
…rability_indicator_legend
…rability_indicator
…rability_indicator
…rability_indicator_legend
…773_vulnerability_indicator_legend
…o RSC-1774_vulnerability_score
…773_vulnerability_indicator_legend
…o RSC-1774_vulnerability_score
…773_vulnerability_indicator_legend
…o RSC-1774_vulnerability_score
…yIndicatorPage.tsx Co-authored-by: Ross Pokorny <[email protected]>
rpokorny
reviewed
Oct 11, 2024
lib/src/components/NxVulnerabilityIndicator/NxVulnerabilityIndicator.tsx
Outdated
Show resolved
Hide resolved
…yIndicatorPage.tsx Co-authored-by: Ross Pokorny <[email protected]>
…abilityIndicatorLegendPage.tsx Co-authored-by: Ross Pokorny <[email protected]>
rpokorny
reviewed
Oct 11, 2024
| expect(vulnerabilityIndicator).toBeInTheDocument(); | ||
| }); | ||
|
|
||
| it('takes precedence of severityLevel if both props are provided', async function() { |
There was a problem hiding this comment.
Something's wrong if this is passing; the prop is called severityRating
There was a problem hiding this comment.
Fixed tests for NxVulnerabilityIndicator here: 3be4a99
rpokorny
reviewed
Oct 11, 2024
| }); | ||
|
|
||
| it('sets the accessible name based on the severity level', async function() { | ||
| const el = quickRender({ score: '9.0', severityLevel: 'low' }); |
rpokorny
reviewed
Oct 11, 2024
| return tooltip.textContent; | ||
| }; | ||
|
|
||
| describe('when vulnerabilityScore prop is provided', function() { |
There was a problem hiding this comment.
Fewer tests of values in the middle of each range, more tests of values at the edges of each range.
rpokorny
reviewed
Oct 11, 2024
| }); | ||
| }); | ||
|
|
||
| describe('when vulnerabilitySeverityLevel prop is provided', function() { |
rpokorny
reviewed
Oct 11, 2024
| @use '../../scss-shared/nx-dark-mode-helpers'; | ||
|
|
||
| .nx-vulnerability-indicator-legend { | ||
| $max-grid-columns: 6; |
rpokorny
reviewed
Oct 11, 2024
Comment on lines
30
to
40
| const { | ||
| critical, | ||
| high, | ||
| medium, | ||
| low, | ||
| none, | ||
| vertical, | ||
| header, | ||
| className, | ||
| ...attrs | ||
| } = props; |
rpokorny
reviewed
Oct 11, 2024
.../components/NxVulnerabilityIndicatorLegend/__tests__/NxVulnerabilityIndicatorLegend.test.tsx
Outdated
Show resolved
Hide resolved
…stExample.tsx Co-authored-by: Ross Pokorny <[email protected]>
…/sonatype/sonatype-react-shared-components into RSC-1772_vulnerability_indicator
Co-authored-by: Ross Pokorny <[email protected]>
…icator.scss Co-authored-by: Ross Pokorny <[email protected]>
…VulnerabilityIndicatorLegend.test.tsx Co-authored-by: Ross Pokorny <[email protected]>
rpokorny
reviewed
Oct 11, 2024
lib/src/components/NxVulnerabilityIndicator/NxVulnerabilityIndicator.tsx
Outdated
Show resolved
Hide resolved
…icator.tsx Co-authored-by: Ross Pokorny <[email protected]>
rpokorny
reviewed
Oct 11, 2024
| $-vertical-alignment: -0.1em; | ||
|
|
||
| .nx-vulnerability-indicator { | ||
| font-size: var(--nx-font-size-s); |
There was a problem hiding this comment.
The visible shape of this fontawesome icon doesn't take up the full height of its <svg> box: the <svg> is 14px tall but the visible square is only 12.5px tall whereas it's supposed to be 14px. As it happens, this can be fixed by using the regular 16px font size, causing the visible square to come out to the desired 14px. And then, since the "font size" of the icon is the same as that of the adjacent text, we don't have to use a custom vertical-align.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: https://sonatype.atlassian.net/browse/RSC-1769
Subtasks: