gNOI HLD for OS, reboot, File, Reset services #1762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Adding @vvolam @lguohan @qiluo-msft and @hdwhdw for review. Thanks! |
hdwhdw
reviewed
Nov 7, 2024
|
|
||
| a. Set the version field of the ActivateRequest message to be the same as the version specified in the TransferRequest message above. | ||
|
|
||
| b. Set the no_reboot flag to true. |
There was a problem hiding this comment.
Is this a server-side requirement (so as the standby_supervisor)? I am all for this but we should probably document, so client don't make unsupported rpc calls.
| * Verify the standby supervisor version. | ||
| * Expect that the VerifyResponse.verify_standby has the same version in messages above. | ||
|
|
||
| Configuration push verification post OS update. |
|
|
||
| ## Scope | ||
|
|
||
| This document describes the high level design of adding the capability to support gNOI APIs for OS, Reboot, File, Factory Reset services in the telemetry server. |
There was a problem hiding this comment.
Can we be a bit more specific about what RPC exactly (maybe make a list) that we implement? For example, OS has three RPCs but Reboot is a RPC under System service, so it doesn't make that much sense to put them side by side.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.