-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DASH] Undeprecate ENI table pl_sip_encoding #1805
Merged
prsunny
merged 2 commits into
sonic-net:master
from
theasianpianist:undeprecate-pl-sip-encoding
Sep 23, 2024
Merged
[DASH] Undeprecate ENI table pl_sip_encoding #1805
prsunny
merged 2 commits into
sonic-net:master
from
theasianpianist:undeprecate-pl-sip-encoding
Sep 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lawrence Lee <[email protected]>
prsunny
pushed a commit
to sonic-net/sonic-swss
that referenced
this pull request
Sep 11, 2024
What I did If present, parse pl_sip_encoding field in ENI table and pass it to SAI Why I did it pl_sip_encoding was previously deprecated but now has been un-deprecated (see sonic-net/SONiC#1805)
@mukeshmv for viz |
mukeshmv
approved these changes
Sep 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Signed-off-by: Lawrence Lee <[email protected]>
mukeshmv
approved these changes
Sep 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
mukeshmv
reviewed
Sep 18, 2024
shuaishang
pushed a commit
to wenwang00/sonic-swss
that referenced
this pull request
Sep 18, 2024
What I did If present, parse pl_sip_encoding field in ENI table and pass it to SAI Why I did it pl_sip_encoding was previously deprecated but now has been un-deprecated (see sonic-net/SONiC#1805)
prsunny
approved these changes
Sep 23, 2024
a114j0y
pushed a commit
to a114j0y/SONiC
that referenced
this pull request
Oct 23, 2024
[DASH] Undeprecate ENI table pl_sip_encoding (sonic-net#1805) * pl_sip_encoding was recently undeprecated, so update the HLD accordingly. * Update privatelink configuration examples to reflect pl_sip_encoding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pl_sip_encoding
was recently undeprecated, so update the HLD accordingly.pl_sip_encoding