Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DASH] Undeprecate ENI table pl_sip_encoding #1805

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

theasianpianist
Copy link
Contributor

  • pl_sip_encoding was recently undeprecated, so update the HLD accordingly.
  • Update privatelink configuration examples to reflect pl_sip_encoding

Signed-off-by: Lawrence Lee <[email protected]>
prsunny pushed a commit to sonic-net/sonic-swss that referenced this pull request Sep 11, 2024
What I did
If present, parse pl_sip_encoding field in ENI table and pass it to SAI

Why I did it
pl_sip_encoding was previously deprecated but now has been un-deprecated (see sonic-net/SONiC#1805)
@theasianpianist
Copy link
Contributor Author

@mukeshmv for viz

Copy link
Contributor

@mukeshmv mukeshmv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Signed-off-by: Lawrence Lee <[email protected]>
Copy link
Contributor

@mukeshmv mukeshmv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

shuaishang pushed a commit to wenwang00/sonic-swss that referenced this pull request Sep 18, 2024
What I did
If present, parse pl_sip_encoding field in ENI table and pass it to SAI

Why I did it
pl_sip_encoding was previously deprecated but now has been un-deprecated (see sonic-net/SONiC#1805)
@prsunny prsunny merged commit 6d9dc4f into sonic-net:master Sep 23, 2024
1 check passed
a114j0y pushed a commit to a114j0y/SONiC that referenced this pull request Oct 23, 2024
[DASH] Undeprecate ENI table pl_sip_encoding (sonic-net#1805)
* pl_sip_encoding was recently undeprecated, so update the HLD accordingly.
* Update privatelink configuration examples to reflect pl_sip_encoding
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants