Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Nokia][sonic-platform] Update Nokia sonic-platform submodule - SFP s… #16572

Merged
merged 1 commit into from
Sep 23, 2023

Conversation

snider-nokia
Copy link
Contributor

@snider-nokia snider-nokia commented Sep 15, 2023

This fixes https://github.com/Nokia-ION/ndk/issues/22
Note that this PR must be coupled with NDK version >= 22.9.13

Why I did it

To provide proper support for CMIS compliant transceiver module CDB operations (including FW related operations).

How I did it

Enhanced the transport subsystem so as to provide for up to 2k bytes of data to be passed to/from modules (as contrasted with the prior max of 128 bytes).

How to verify it

Ensure that new FW (firmware) can be programmed to CMIS compliant module(s) using the 'sfputil firmware ...' commands.

admin@ixre-egl-board29:~$ sudo sfputil firmware download Ethernet112 /tmp/560-0087-28_Rev_61.22.21_dp04qsdd_dp04sfp8.ackit
CDB: Starting firmware download
Downloading ... [###################################-] 99% 00:00:00
CDB: firmware download complete
Firmware download complete success
Total download Time: 0:03:53.455740

admin@ixre-egl-board29:~$ sudo sfputil firmware download Ethernet112 /tmp/560-0087-23_Rev_61.20.13_dp04qsdd_dp04sfp8.ackit
CDB: Starting firmware download
Downloading ... [###################################-] 99% 00:00:00
CDB: firmware download complete
Firmware download complete success
Total download Time: 0:03:51.552884

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Tested with branch 202205

Description for the changelog

Properly support CDB operations for CMIS transceiver modules
Note that this PR must be coupled with NDK version >= 22.9.13

@snider-nokia
Copy link
Contributor Author

@vmittal-msft and/or @prgeor, can you please review?

Merging should be discussed in conjunction with release of NDK version >= 22.9.13 (as the two components must be coupled).

@gechiang
Copy link
Collaborator

@judyjoseph can you help review this? Will also tag you to review the new ndk 22.9.13 PR...

@prgeor
Copy link
Contributor

prgeor commented Sep 22, 2023

@snider-nokia could you please share the logs in the PR description for the firmware download steps?

@lguohan lguohan merged commit 5aea3a9 into sonic-net:master Sep 23, 2023
10 checks passed
@lguohan lguohan added the device label Sep 23, 2023
@gechiang gechiang added the Chassis for 202205 branch PRs needed for 202205 branch in msft repo label Sep 25, 2023
@gechiang
Copy link
Collaborator

@snider-nokia , Before this is picked into 202205 MSFT repo, the required NDK needs to be picked to 202205 MSFT repo first. Can you please create the needed PR for sonic-net/sonic-buildimage-msft#112 for 202205 MSFT branch?
Once that is done, I will try to cherry-pick this to 202205 MSFT repo.
Thanks!

@mlok-nokia
Copy link
Contributor

mlok-nokia commented Sep 25, 2023

@snider-nokia , Before this is picked into 202205 MSFT repo, the required NDK needs to be picked to 202205 MSFT repo first. Can you please create the needed PR for Azure/sonic-buildimage-msft#112 for 202205 MSFT branch? Once that is done, I will try to cherry-pick this to 202205 MSFT repo. Thanks!

@gechiang Related NDK PR has been created: sonic-net/sonic-buildimage-msft#118

@gechiang
Copy link
Collaborator

@lguohan , @yxieca , @StormLiangMS:
MSFT ADO: 25264667
Please help approve for the corresponding release.
Thanks!

@mssonicbld
Copy link
Collaborator

@snider-nokia PR conflicts with 202211 branch

mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Sep 25, 2023
…upport for CMIS CDB operations (sonic-net#16572)

This fixes Nokia-ION/ndk#22
Note that this PR must be coupled with NDK version >= 22.9.13

Why I did it
To provide proper support for CMIS compliant transceiver module CDB operations (including FW related operations).

How I did it
Enhanced the transport subsystem so as to provide for up to 2k bytes of data to be passed to/from modules (as contrasted with the prior max of 128 bytes).

How to verify it
Ensure that new FW (firmware) can be programmed to CMIS compliant module(s) using the 'sfputil firmware ...' commands.
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202205: #16688

mssonicbld pushed a commit that referenced this pull request Sep 26, 2023
…upport for CMIS CDB operations (#16572)

This fixes Nokia-ION/ndk#22
Note that this PR must be coupled with NDK version >= 22.9.13

Why I did it
To provide proper support for CMIS compliant transceiver module CDB operations (including FW related operations).

How I did it
Enhanced the transport subsystem so as to provide for up to 2k bytes of data to be passed to/from modules (as contrasted with the prior max of 128 bytes).

How to verify it
Ensure that new FW (firmware) can be programmed to CMIS compliant module(s) using the 'sfputil firmware ...' commands.
mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Oct 7, 2023
…upport for CMIS CDB operations (sonic-net#16572)

This fixes Nokia-ION/ndk#22
Note that this PR must be coupled with NDK version >= 22.9.13

Why I did it
To provide proper support for CMIS compliant transceiver module CDB operations (including FW related operations).

How I did it
Enhanced the transport subsystem so as to provide for up to 2k bytes of data to be passed to/from modules (as contrasted with the prior max of 128 bytes).

How to verify it
Ensure that new FW (firmware) can be programmed to CMIS compliant module(s) using the 'sfputil firmware ...' commands.
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202305: #16796

@gechiang
Copy link
Collaborator

@snider-nokia , do you intent to backport this to 202211 branch? If not, I will withdraw request for 202211 branch.
Please help clarify this or resolve the cherry-pick conflict for 202211 branch by raising a separate PR for 202211 for this change.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants