You have commit messages with errors ⧗ input: lib, mgmtd: fix processing of yang notifications Current code assumes that notification is always sent in stripped JSON format and therefore notification xpath starts at the third symbol of notification data. Assuming JSON is more or less fine, because this representation is internal to FRR, but the assumption about the xpath is wrong, because it won't work for not top-level notifications. YANG allows to define notification as a child for some data node deep into the tree and in this case notification data contains not only the notification node itself, but also all its parents. To fix the issue, parse the notification data and get its xpath from its schema node. Signed-off-by: Igor Ryzhov <[email protected]> ✖ type may not be empty [type-empty] ✖ subject may not be empty [subject-empty] ✖ found 2 problems, 0 warnings ⓘ Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint ⧗ input: qpb: Add missing `#include nexthop.h` In `qpb.h` we have a bunch of functions that make use of `union g_addr`. `union g_addr` is defined in `nexthop.h`, which actually is NOT included in `qpb.h`. Let's add the missing `#include nexthop.h`. Signed-off-by: Carmine Scarpitta <[email protected]> ✖ type must be one of [babeld, bfdd, bgpd, build, doc, docker, eigrpd, fpm, isisd, ldpd, lib, mgmtd, multi, nhrpd, ospf6d, ospfd, pathd, pbrd, pimd, pim6d, ripd, ripngd, sharpd, staticd, tests, tools, vtysh, vrrpd, yang, zebra, all] [type-enum] ✖ found 1 problems, 0 warnings ⓘ Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint ⧗ input: lib, mgmtd: rework processing of yang notifications Currently, YANG notification processing is done using a special type of callbacks registered in backend clients. In this commit, we start using regular northbound infrastructure instead, because it already has a convenient way of registering xpath-specific callbacks without the need for creating additional structures for each necessary notification. We also now pass a notification data to the callback, instead of a plain JSON. This allows to use regular YANG library functions for inspecting notification fields, instead of manually parsing the JSON. Signed-off-by: Igor Ryzhov <[email protected]> ✖ type may not be empty [type-empty] ✖ subject may not be empty [subject-empty] ✖ found 2 problems, 0 warnings ⓘ Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint ⧗ input: bgpd, yang: fix missing mandatory/default statements on some leafs The code expects these leafs to always exist. If they are not set, the daemon would crash. CLI always sets them, but we should properly mark them as mandatory/default to prevent them from being missed when using the API. Signed-off-by: Igor Ryzhov <[email protected]> (cherry picked from commit 83a3b0f10f994ee5adbbef0f6bd970b69eab4486) ✖ type may not be empty [type-empty] ✖ subject may not be empty [subject-empty] ✖ found 2 problems, 0 warnings ⓘ Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint ⧗ input: bmp: fix vty_out for monitor afi loc-rib "show run" displays BMP monitor AFI in upper case. > bmp targets bmp1 > bmp monitor IPv4 unicast loc-rib Display it in lower case. > bmp targets bmp1 > bmp monitor ipv4 unicast loc-rib Signed-off-by: Farid Mihoub <[email protected]> Signed-off-by: Louis Scalbert <[email protected]> (cherry picked from commit 3104d482e932c7a030d8a5e209ed33ec151953f7) ✖ type must be one of [babeld, bfdd, bgpd, build, doc, docker, eigrpd, fpm, isisd, ldpd, lib, mgmtd, multi, nhrpd, ospf6d, ospfd, pathd, pbrd, pimd, pim6d, ripd, ripngd, sharpd, staticd, tests, tools, vtysh, vrrpd, yang, zebra, all] [type-enum] ✖ found 1 problems, 0 warnings ⓘ Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint ⧗ input: topotests: add an ebgp 6vpe test This test uses the connected ipv4 mapped ipv6 prefix to resolve the received BGP routes. Signed-off-by: L