Add support of heartbeat interval in "ON_CHANGE" subscription #159
+81
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FengPan-Frank
force-pushed
the
fenpan_heartbeat
branch
from
d57f25b
to
dc18626
Compare
FengPan-Frank
force-pushed
the
fenpan_heartbeat
branch
from
dc18626
to
a46dd46
Compare
FengPan-Frank
changed the title
FengPan-Frank
changed the title
FengPan-Frank
force-pushed
the
fenpan_heartbeat
branch
from
a46dd46
to
c03d8e3
Compare
full sync would happen periodically when hb is triggered.
FengPan-Frank
force-pushed
the
fenpan_heartbeat
branch
from
c03d8e3
to
f1a80fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support of heartbeat interval in "on change" subscription so that full sync would happen periodically when hb is triggered.
Why I did it
https://github.com/openconfig/gnmi/blob/5473f2ef722ee45c3f26eee3f4a44a7d827e3575/proto/gnmi/gnmi.proto#L309, gnmi protobuf already reserved for this support, we need this for periodically full sync from StreamTelemetry subscriber perspective.
How I did it
File ticker and re-sync all the updates, the minimal hb value should be assigned after existing bgp route monitoring benchmark is done.
How to verify it
On Image and unit test.
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)