Add execute_reboot dbus_interface #164
Open
+76
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hdwhdw
approved these changes
Sep 16, 2024
prgeor
reviewed
Sep 18, 2024
saiarcot895
reviewed
Sep 18, 2024
|
Please update the tests. |
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
qiluo-msft
reviewed
Sep 20, 2024
qiluo-msft
reviewed
Sep 20, 2024
| if rebootmethod in REBOOTMETHOD_COLD_BOOT_VALUES: | ||
| cmd = ['/usr/local/bin/reboot'] | ||
| elif rebootmethod in REBOOTMETHOD_HALT_BOOT_VALUES: | ||
| cmd = ['/usr/local/bin/reboot','-p'] |
There was a problem hiding this comment.
@qiluo-msft, this change is upcoming in sonic-utilties which is work-in-progress. If the existing image does not have "-p", command will fail. Thank you!
qiluo-msft
reviewed
Sep 20, 2024
hdwhdw
requested changes
Sep 20, 2024
| from unittest import mock | ||
| from host_modules import systemd_service | ||
|
|
||
| class RebootMethod(Enum): |
There was a problem hiding this comment.
Can you take a look at https://github.com/openconfig/gnoi/blob/8e23e5d63965c3787a5331e330b3a9450a302130/system/system.proto#L78
If you import system.pb.go that the proto generated, you will get access to this exact enum. Please don't redefine it as it might leads to conflict in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of sonic-net/sonic-gnmi#286 changes, we require dbus support for executing HALT method.
This PR adds support for execute_reboot for invoking reboot methods.