Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SAIP4] Add vlan match to acl_pre_ingress_vlan_table, Disallow matching on reserved VLAN ids & Add fixed action id for no_action action in routing.p4 #571

Closed

Conversation

divyagayathri-hcl
Copy link
Contributor

@divyagayathri-hcl divyagayathri-hcl commented Sep 20, 2024

Keyword Check:

sdivya@eonms6vm1:~/sonic_sep6/sonic-buildimage/src/sonic-p4rt/sonic-pins$ ~/keyword_check.sh .
Keyword check Passed.

Build and Test Results:

...
INFO: Elapsed time: 1413.653s, Critical Path: 89.97s
INFO: 3029 processes: 3051 linux-sandbox, 18 local.
INFO: Build completed successfully, 3029 total actions
//gutil:collections_test PASSED in 0.6s
//gutil:io_test PASSED in 0.7s
//gutil:proto_matchers_test PASSED in 0.8s
//gutil:proto_ordering_test PASSED in 0.6s
//gutil:proto_test PASSED in 0.5s
//gutil:status_matchers_test PASSED in 0.7s
//gutil:test_artifact_writer_test PASSED in 0.6s
//gutil:testing_test PASSED in 0.5s
//gutil:timer_test PASSED in 5.1s
//gutil:version_test PASSED in 0.9s
//lib:basic_switch_test PASSED in 0.9s
//lib:ixia_helper_test PASSED in 1.6s
//lib/basic_traffic:basic_p4rt_util_test PASSED in 0.9s
//lib/basic_traffic:basic_traffic_test PASSED in 14.9s
//lib/gnmi:gnmi_helper_test PASSED in 2.9s
//lib/gnoi:gnoi_helper_test PASSED in 0.5s
//lib/p4rt:p4rt_port_test PASSED in 0.8s
//lib/p4rt:p4rt_programming_context_test PASSED in 0.8s
//lib/utils:generic_testbed_utils_test PASSED in 1.2s
//lib/utils:json_utils_test PASSED in 0.6s
//lib/validator:validator_backend_test PASSED in 0.7s
//lib/validator:validator_lib_test PASSED in 25.9s
//p4_fuzzer:constraints_util_integration_test PASSED in 0.7s
//p4_fuzzer:fuzz_util_test PASSED in 9.2s
//p4_fuzzer:oracle_util_test PASSED in 1.0s
//p4_fuzzer:switch_state_test PASSED in 0.7s
//p4_fuzzer:table_entry_key_test PASSED in 0.1s
//p4_pdpi:built_ins_test PASSED in 0.6s
//p4_pdpi:entity_keys_test PASSED in 0.7s
//p4_pdpi:ir_properties_test PASSED in 0.6s
//p4_pdpi:ir_to_ir_test PASSED in 0.6s
//p4_pdpi:ir_tools_test PASSED in 0.8s
//p4_pdpi:names_test PASSED in 0.7s
//p4_pdpi:p4_runtime_matchers_test PASSED in 0.6s
//p4_pdpi:reference_annotations_test PASSED in 0.7s
//p4_pdpi:references_test PASSED in 0.6s
//p4_pdpi:sequencing_util_test PASSED in 0.6s
//p4_pdpi/netaddr:ipv4_address_and_network_address_test PASSED in 0.7s
//p4_pdpi/netaddr:ipv6_address_test PASSED in 0.6s
//p4_pdpi/netaddr:mac_address_test PASSED in 0.5s
//p4_pdpi/packetlib:packetlib_fuzzer_test PASSED in 16.5s
//p4_pdpi/packetlib:packetlib_matchers_test PASSED in 0.6s
//p4_pdpi/packetlib:packetlib_test PASSED in 0.2s
//p4_pdpi/packetlib:packetlib_test_runner PASSED in 0.3s
//p4_pdpi/packetlib:packetlib_unit_test PASSED in 2.8s
//p4_pdpi/string_encodings:bit_string_test PASSED in 0.5s
//p4_pdpi/string_encodings:byte_string_test PASSED in 0.5s
//p4_pdpi/string_encodings:decimal_string_test PASSED in 0.0s
//p4_pdpi/string_encodings:decimal_string_test_runner PASSED in 0.1s
//p4_pdpi/string_encodings:hex_string_test PASSED in 0.1s
//p4_pdpi/string_encodings:hex_string_test_runner PASSED in 0.0s
//p4_pdpi/string_encodings:readable_byte_string_test PASSED in 0.5s
//p4_pdpi/testing:helper_function_test PASSED in 0.7s
//p4_pdpi/testing:info_test PASSED in 0.4s
//p4_pdpi/testing:info_test_runner PASSED in 0.1s
//p4_pdpi/testing:main_pd_test PASSED in 0.1s
//p4_pdpi/testing:mock_p4_runtime_server_test PASSED in 0.7s
//p4_pdpi/testing:old_get_entries_unreachable_from_roots_with_matchfield_reference_test PASSED in 0.3s
//p4_pdpi/testing:old_get_entries_unreachable_from_roots_with_matchfield_reference_test_runner PASSED in 0.1s
//p4_pdpi/testing:packet_io_test PASSED in 0.6s
//p4_pdpi/testing:packet_io_test_runner PASSED in 0.1s
//p4_pdpi/testing:references_test PASSED in 0.3s
//p4_pdpi/testing:references_test_runner PASSED in 0.1s
//p4_pdpi/testing:rpc_test PASSED in 0.3s
//p4_pdpi/testing:rpc_test_runner PASSED in 0.1s
//p4_pdpi/testing:sequencing_test PASSED in 0.3s
//p4_pdpi/testing:sequencing_test_runner PASSED in 0.1s
//p4_pdpi/testing:sequencing_util_test PASSED in 0.1s
//p4_pdpi/testing:sequencing_util_test_runner PASSED in 0.3s
//p4_pdpi/testing:table_entry_gunit_test PASSED in 1.0s
//p4_pdpi/testing:table_entry_test PASSED in 0.4s
//p4_pdpi/testing:table_entry_test_runner PASSED in 0.1s
//p4_pdpi/utils:annotation_parser_test PASSED in 0.5s
//p4_pdpi/utils:ir_test PASSED in 0.7s
//p4_symbolic/bmv2:ipv4_routing_exact_test PASSED in 0.1s
//p4_symbolic/bmv2:ipv4_routing_subset_test PASSED in 0.1s
//p4_symbolic/bmv2:port_hardcoded_exact_test PASSED in 0.0s
//p4_symbolic/bmv2:port_hardcoded_subset_test PASSED in 0.2s
//p4_symbolic/bmv2:port_table_exact_test PASSED in 0.0s
//p4_symbolic/bmv2:port_table_subset_test PASSED in 0.1s
//p4_symbolic/bmv2:reflector_exact_test PASSED in 0.0s
//p4_symbolic/bmv2:reflector_subset_test PASSED in 0.1s
//p4_symbolic/ir:ipv4_routing_test PASSED in 0.0s
//p4_symbolic/ir:port_hardcoded_test PASSED in 0.0s
//p4_symbolic/ir:port_table_test PASSED in 0.0s
//p4_symbolic/ir:reflector_test PASSED in 0.0s
//p4_symbolic/symbolic:ipv4_routing_test_output PASSED in 0.1s
//p4_symbolic/symbolic:port_hardcoded_test_output PASSED in 0.0s
//p4_symbolic/symbolic:port_table_test_output PASSED in 0.1s
//p4_symbolic/symbolic:reflector_test_output PASSED in 0.1s
//p4rt_app/event_monitoring:app_state_db_port_table_event_test PASSED in 1.2s
//p4rt_app/event_monitoring:app_state_db_send_to_ingress_port_table_event_test PASSED in 0.9s
//p4rt_app/event_monitoring:config_db_cpu_queue_table_event_test PASSED in 1.2s
//p4rt_app/event_monitoring:config_db_node_cfg_table_event_test PASSED in 1.0s
//p4rt_app/event_monitoring:config_db_port_table_event_test PASSED in 1.1s
//p4rt_app/event_monitoring:debug_data_dump_events_test PASSED in 1.2s
//p4rt_app/event_monitoring:state_verification_events_test PASSED in 1.0s
//p4rt_app/p4runtime:cpu_queue_translator_test PASSED in 0.6s
//p4rt_app/p4runtime:ir_translation_test PASSED in 1.0s
//p4rt_app/p4runtime:p4info_verification_schema_test PASSED in 0.8s
//p4rt_app/p4runtime:p4info_verification_test PASSED in 1.0s
//p4rt_app/p4runtime:packetio_helpers_test PASSED in 1.0s
//p4rt_app/p4runtime:resource_utilization_test PASSED in 0.8s
//p4rt_app/sonic:app_db_acl_def_table_manager_test PASSED in 0.9s
//p4rt_app/sonic:app_db_manager_test PASSED in 0.8s
//p4rt_app/sonic:app_db_to_pdpi_ir_translator_test PASSED in 0.8s
//p4rt_app/sonic:hashing_test PASSED in 0.8s
//p4rt_app/sonic:packet_replication_entry_translation_test PASSED in 0.7s
//p4rt_app/sonic:packetio_impl_test PASSED in 1.1s
//p4rt_app/sonic:packetio_port_test PASSED in 0.6s
//p4rt_app/sonic:response_handler_test PASSED in 0.8s
//p4rt_app/sonic:state_verification_test PASSED in 1.0s
//p4rt_app/sonic:vrf_entry_translation_test PASSED in 0.7s
//p4rt_app/sonic/adapters:fake_sonic_db_table_test PASSED in 0.1s
//p4rt_app/sonic/adapters:fake_warm_boot_state_adapter_test PASSED in 0.4s
//p4rt_app/tests:acl_table_test PASSED in 2.0s
//p4rt_app/tests:action_set_test PASSED in 1.5s
//p4rt_app/tests:api_access_test PASSED in 1.2s
//p4rt_app/tests:arbitration_test PASSED in 1.6s
//p4rt_app/tests:cpu_queue_name_and_id_test PASSED in 2.4s
//p4rt_app/tests:debug_data_dump_test PASSED in 1.4s
//p4rt_app/tests:fixed_l3_tables_test PASSED in 3.7s
//p4rt_app/tests:forwarding_pipeline_config_test PASSED in 6.8s
//p4rt_app/tests:grpc_behavior_test PASSED in 5.5s
//p4rt_app/tests:p4_constraints_test PASSED in 0.2s
//p4rt_app/tests:p4_constraints_test_runner PASSED in 0.5s
//p4rt_app/tests:p4_programs_test PASSED in 2.3s
//p4rt_app/tests:packet_replication_table_test PASSED in 2.5s
//p4rt_app/tests:packetio_test PASSED in 4.5s
//p4rt_app/tests:port_name_and_id_test PASSED in 4.0s
//p4rt_app/tests:resource_limits_test PASSED in 2.0s
//p4rt_app/tests:response_path_test PASSED in 4.2s
//p4rt_app/tests:role_test PASSED in 1.5s
//p4rt_app/tests:state_verification_test PASSED in 2.4s
//p4rt_app/tests:vrf_table_test PASSED in 2.0s
//p4rt_app/tests/lib:app_db_entry_builder_test PASSED in 0.0s
//p4rt_app/utils:event_data_tracker_test PASSED in 0.1s
//p4rt_app/utils:table_utility_test PASSED in 0.7s
//sai_p4/instantiations/google:clos_stage_test PASSED in 1.1s
//sai_p4/instantiations/google:fabric_border_router_p4info_up_to_date_test PASSED in 0.1s
//sai_p4/instantiations/google:middleblock_p4info_up_to_date_test PASSED in 0.0s
//sai_p4/instantiations/google:sai_p4info_fetcher_test PASSED in 0.7s
//sai_p4/instantiations/google:sai_p4info_test PASSED in 1.0s
//sai_p4/instantiations/google:sai_pd_proto_test PASSED in 0.0s
//sai_p4/instantiations/google:sai_pd_util_test PASSED in 0.6s
//sai_p4/instantiations/google:tor_p4info_up_to_date_test PASSED in 0.0s
//sai_p4/instantiations/google:union_p4info_up_to_date_test PASSED in 0.1s
//sai_p4/instantiations/google:wbb_p4info_up_to_date_test PASSED in 0.0s
//sai_p4/instantiations/google/test_tools:table_entry_generator_helper_test PASSED in 1.7s
//sai_p4/instantiations/google/test_tools:test_entries_test PASSED in 0.8s
//sai_p4/instantiations/google/tests:p4_constraints_integration_test PASSED in 0.8s
//sai_p4/tools:p4info_tools_test PASSED in 0.6s
//sai_p4/tools:packetio_tools_test PASSED in 0.7s
//thinkit:bazel_test_environment_test PASSED in 0.8s
//thinkit:generic_testbed_test PASSED in 0.8s
//thinkit:mock_control_device_test PASSED in 0.7s
//thinkit:mock_generic_testbed_test PASSED in 0.7s
//thinkit:mock_mirror_testbed_test PASSED in 2.0s
//thinkit:mock_ssh_client_test PASSED in 0.0s
//thinkit:mock_switch_test PASSED in 0.8s
//thinkit:mock_test_environment_test PASSED in 0.1s
//thinkit:switch_test PASSED in 0.8s
//sai_p4/instantiations/google/test_tools:table_entry_generator_test PASSED in 32.6s
Stats over 5 runs: max = 32.6s, min = 2.2s, avg = 12.1s, dev = 11.1s

Executed 163 out of 163 tests: 163 tests pass.
There were tests whose specified size is too big. Use the --test_verbose_timeout_warnings command line option to see which ones these aINFO: Build completed successfully, 3029 total actions

@divyagayathri-hcl
Copy link
Contributor Author

Co-authored-by: kheradmandG [email protected]

@kishanps
Copy link
Collaborator

@divyagayathri-hcl Can you pls resolve the conflicts

kheradmandG and others added 4 commits September 23, 2024 17:16
…e to account for empty group case, Add EtherType qualifier to acl_pre_ingress_vlan_table, Increase tunnel table guaranteed size to 2k, Add an `in_port` match key to the ACL Pre-Ingress Metadata table, Rename `*_ttl_rewrite` to `*_decrement_ttl` to be more aligned with SAI API, fix format and update comment, Move @id(ROUTING_WCMP_GROUP_SELECTOR_ACTION_PROFILE_ID) to the correct place, Re-enable a disabled assertion, Fix bug causing acl_ingress_security match fields to not exist on ToR, Add action that only sets cpu queue to acl_ingress_qos_table, Specify that QoS queue is a CPU queue for set_cpu_queue_and_deny_above_rate_limit & Uncomment DENY actions since these are supported by OA.
…ngress QoS table & Add support for disabling VLAN rewrite.
…ng on reserved VLAN ids & Add fixed action id for no_action action in routing.p4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants