Fix CMIS and preemphasis lane mapping issues #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jemifdo
commented
Jul 3, 2024
jemifdo
commented
- CMIS port db is updated dynamically on DPB
- check_datapath_init_pending is disabled as it need to be done for different lanes sequentially instead of concurrent
- Preemphasis to lane map now works when not all lanes of the port are used
- get_physical_to_logical is now sorted to generated the correct preemphasis values
- CMIS port db is updated dynamically on DPB - check_datapath_init_pending is disabled as it need to be done for different lanes sequentially instead of concurrent - Preemphasis to lane map now works when not all lanes of the port are used - get_physical_to_logical is now sorted to generated the correct preemphasis values - Add API to support the selection of the preemphasis key in a platform vendor dictated way instead of generic one
prgeor
requested changes
Jul 5, 2024
|
@prgeor I mean the case where 1x100G breakout mode is used in an 8 lane port (with speed 25G per lane) and for this the preemphasis dict must have values only the first four lanes. Remaining 4 lanes are unused by the port. |
'subport' is now part of the PORT config, so does not require any derivation
jemifdo
force-pushed
the
202311_cmis_stub
branch
from
c82d975
to
072396b
Compare
jemifdo
force-pushed
the
202311_cmis_stub
branch
from
072396b
to
894a51c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.