[Link Event Damping] Add Abstract SelectEventHandler class to handle link event damping timer events. #1312
Conversation
Ashish1805
force-pushed
the
ledamping_seh
branch
from
c4df0f4 to
d144513
Compare
|
Adding @Junchao-Mellanox for review. |
syncd/SelectableEventHandler.h
Outdated
|
|
||
| protected: | ||
|
|
||
| SelectableEventHandler() |
There was a problem hiding this comment.
do we really need this?
There was a problem hiding this comment.
Why constructor is protected ?
syncd/SelectableEventHandler.h
Outdated
|
|
||
| protected: | ||
|
|
||
| SelectableEventHandler() |
There was a problem hiding this comment.
Why constructor is protected ?
Ashish1805
force-pushed
the
ledamping_seh
branch
from
d144513 to
c794e58
Compare
|
@kcudnik Please let me know if you have any other comments/concerns. If everything looks good, can you please merge the PR? Thank you. |
|
You did not answered my questions about protected constructors |
In another comment reply, I had added the explanation: Strictly speaking constructor is not needed, but constructor was added as protected just to make it clear to clients that they cannot directly instantiate an object of the class. Agree, this class still be uninstantiable because of the pure virtual method, but to put the emphasize on not trying to directly instantiate this class, protected constructor was kept. I am inclined to keep constructor as: Thank you. |
Ashish1805
force-pushed
the
ledamping_seh
branch
from
fd9efeb to
7813cec
Compare
link event damping timer events. - Handler in the class will be used to handle the timer event of link event dampers. HLD: sonic-net/SONiC#1071
Ashish1805
force-pushed
the
ledamping_seh
branch
from
7813cec to
764ec38
Compare
HLD: sonic-net/SONiC#1071