[Link Event Damping] Serialization/deserialization logic for link event damping port attrs #1322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcudnik
reviewed
Nov 16, 2023
|
please fix build errors |
Ashish1805
force-pushed
the
ledamping_sairedis
branch
from
571f6ea to
6d2c4d6
Compare
|
Adding @Junchao-Mellanox for review. |
Ashish1805
force-pushed
the
ledamping_sairedis
branch
from
6d2c4d6 to
3891355
Compare
kcudnik
reviewed
Nov 29, 2023
kcudnik
reviewed
Nov 29, 2023
damping config attr. - Adding serialization/deserialization logic for link event damping config so that when libsai is sending link event damping algo and config to syncd for set request, it uses serialization logic to serialize the requested data before sending the set request and when syncd receives the link event damping port attribute set request, it uses the deserialization logic to deserialize the data. HLD: sonic-net/SONiC#1071
Ashish1805
force-pushed
the
ledamping_sairedis
branch
from
3891355 to
9945dbb
Compare
kcudnik
approved these changes
Nov 30, 2023
|
Hi @Junchao-Mellanox , can you please review the PR once you get a chance? Thank you. |
Junchao-Mellanox
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HLD: sonic-net/SONiC#1071