Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[action] [PR:1341] Revert "add if statement for module control mode support" (#1341) #1346

Merged
merged 1 commit into from
Feb 11, 2024
Merged

[action] [PR:1341] Revert "add if statement for module control mode support" (#1341) #1346

merged 1 commit into from
Feb 11, 2024

Conversation

mssonicbld
Copy link
Collaborator

Reverts #1305

this logic is not needed. we'll change sai.profile directly

@dbarashinvd @mssonicbld
Revert "add if statement for module control mode support" (sonic-net#…
6f6b3af 
…1341)

Reverts sonic-net#1305

this logic is not needed. we'll change sai.profile directly
@mssonicbld
Copy link
Collaborator Author

Original PR: #1341

@mssonicbld mssonicbld mentioned this pull request Jan 31, 2024
Merged
@mssonicbld
Copy link
Collaborator Author

/azp run Azure.sonic-sairedis

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator Author

/azp run Azure.sonic-sairedis

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator Author

/azp run Azure.sonic-sairedis

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator Author

/azp run Azure.sonic-sairedis

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator Author

/azp run Azure.sonic-sairedis

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator Author

/azp run Azure.sonic-sairedis

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dbarashinvd
Copy link
Contributor

/azp run Azure.sonic-sairedis

@azure-pipelines Azure Pipelines
Copy link

Commenter does not have sufficient privileges for PR 1346 in repo sonic-net/sonic-sairedis

@dbarashinvd
Copy link
Contributor

/azpw run

@dbarashinvd
Copy link
Contributor

/azpw run sonic-sairedis

@liat-grozovik
Copy link
Collaborator

/azp run Azure.sonic-sairedis

@azure-pipelines Azure Pipelines
Copy link

Commenter does not have sufficient privileges for PR 1346 in repo sonic-net/sonic-sairedis

@kcudnik
Copy link
Collaborator

kcudnik commented Feb 6, 2024

bulild error on swss is not related to this change, i will investigate why its failinig + @qiluo-msft

@dbarashinvd
Copy link
Contributor

/azpw run Azure.sonic-sairedis

@dbarashinvd
Copy link
Contributor

bulild error on swss is not related to this change, i will investigate why its failinig + @qiluo-msft

hi Kamil, I replied also by email.
seems like the errors already fixed. there were some other PRs failing on the same issue until yesterday night and now few are passing.
can you please check why nothing happens when I try to rerun the failed checkers by commenting with /azpw ?

thanks.

@kcudnik
Copy link
Collaborator

kcudnik commented Feb 6, 2024

im investigating this

@mssonicbld
Copy link
Collaborator Author

/azp run Azure.sonic-sairedis

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator Author

/azp run Azure.sonic-sairedis

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator Author

/azp run Azure.sonic-sairedis

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator Author

/azp run Azure.sonic-sairedis

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator Author

/azp run Azure.sonic-sairedis

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld mssonicbld merged commit 682e860 into sonic-net:202311 Feb 11, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kcudnik kcudnik kcudnik approved these changes

Assignees
No one assigned
Labels
automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mssonicbld @dbarashinvd @liat-grozovik @kcudnik