Use temp view also in fast-reboot #1401
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kcudnik Can you please help reviewing this PR? |
Junchao-Mellanox
approved these changes
Jul 4, 2024
|
@vaibhavhd Can you please reviewing this PR? |
kcudnik
approved these changes
Jul 8, 2024
|
Hi @vaibhavhd , could you please help review this? |
vaibhavhd
reviewed
Aug 12, 2024
| @@ -26,10 +26,8 @@ else | |||
| CMD_ARGS= | |||
| fi | |||
|
|
|||
| # Use temporary view between init and apply except when in fast-reboot | |||
| if [[ "$(cat /proc/cmdline)" != *"SONIC_BOOT_TYPE=fast-reboot"* ]]; then | |||
There was a problem hiding this comment.
We can still keep the check but change the condition. There is a system wide fast-reboot flag that is now used.
May be using that flag is better than 1) removing the check 2) using cmdline which does not change.
Besides, in the current change it is not just fixing the problem with config reload (after fast-reboot). This PR will change the behavior of the fast-reboot as well.
There was a problem hiding this comment.
@vaibhavhd The motivation of this PR is to also use -u in fast-reboot. This is required for PR #1396
vaibhavhd
reviewed
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
syncd_init_common.sh is checking fast-reboot by reading /proc/cmdline. However, /proc/cmdline will not change after config reload. So, consider a case like fast-reboot -> config reload. In the config reload process, syncd_init_common.sh will also treat it as fast-reboot and probably enter wrong logic.