Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[orchagent]: Skip installing ACL counter when ACL mirror rule is inactive #3223

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

[orchagent]: Skip installing ACL counter when ACL mirror rule is inactive #3223

wants to merge 6 commits into from
+23 −1

Commits on Jul 24, 2024

  1. [orchagent]: Resolving issue #18844 

    * Don't install counters when session rule is inactive.

Mirror session is not activated and thus, the ACL rule is not created in sairedis/SAI (there is no next hop for the mirror destination IP).
However, orchagent creates and registers the ACL counter with the flexcounter (FC) and the counter is being polled every polling interval.
Since the ACL counter is not attached to any ACL rule, the BCM SAI introduces print errors in syslog.

Signed-off-by: fountzou <[email protected]>
    @fountzou
    fountzou committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    1844af3 View commit details
    Browse the repository at this point in the history

  2. [orchagent]: Resolving issue #18844 

    * Don't install counters when session rule is inactive.

Mirror session is not activated and thus, the ACL rule is not created in sairedis/SAI (there is no next hop for the mirror destination IP).
However, orchagent creates and registers the ACL counter with the flexcounter (FC) and the counter is being polled every polling interval.
Since the ACL counter is not attached to any ACL rule, the BCM SAI introduces print errors in syslog.

Signed-off-by: fountzou <[email protected]>
    @fountzou
    fountzou committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    347c928 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2024

  1. Code refactoring to improve clarity. 

    Signed-off-by: fountzou <[email protected]>
    @fountzou
    fountzou committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    a1164af View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2024

  1. Merge branch 'master' into issue_18844

    @prsunny
    prsunny committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    d21eaf7 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. Merge branch 'master' into issue_18844

    @fountzou
    fountzou committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    0de72b2 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into issue_18844

    @fountzou
    fountzou committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    ecd9726 View commit details
    Browse the repository at this point in the history