Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[orchagent] implement ring buffer feature with a flag #3242

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

a114j0y
Copy link

@a114j0y a114j0y commented Jul 22, 2024

What I did

  • fix the covariant return type issue of swss::TableBase* Consumer::getConsumerTable() const override
    • it should return swss::ConsumerTableBase *
  • add a ring thread for orchdaemon
  • support ring buffer feature

Why I did it

  • increase the speed for APP_ROUTE_TABLE consumers doing tasks

How I verified it
measure the performance with PerformanceTimer GitHub issue/pull request detail

@siqbal1986
Copy link
Contributor

can you please add sone swss tests for this functionality. There are no tests mentioned in the PR. if you have created a separate PR , Please link it here.

@siqbal1986 siqbal1986 self-requested a review August 23, 2024 18:23
Copy link
Contributor

@siqbal1986 siqbal1986 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is hte need of rign buffer. Can you please add some detail regarding its need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants