Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PVST feature support #3275

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bendrapubalareddy
Copy link

@bendrapubalareddy bendrapubalareddy commented Sep 2, 2024

**** Please hold on review, will remove this line once ready for review **********
Changes:
modified: cfgmgr/Makefile.am
new file: cfgmgr/stpmgr.cpp
new file: cfgmgr/stpmgr.h
new file: cfgmgr/stpmgrd.cpp
modified: configure.ac
modified: orchagent/Makefile.am
modified: orchagent/orchdaemon.cpp
modified: orchagent/orchdaemon.h
modified: orchagent/port.h
modified: orchagent/portsorch.cpp
modified: orchagent/saihelper.cpp
new file: orchagent/stporch.cpp
new file: orchagent/stporch.h
new file: swssconfig/sample/00-copp.config.json
modified: tests/mock_tests/Makefile.am

What I did

Why I did it

How I verified it

Details if related

 Changes:
       modified:   cfgmgr/Makefile.am
       new file:   cfgmgr/stpmgr.cpp
       new file:   cfgmgr/stpmgr.h
       new file:   cfgmgr/stpmgrd.cpp
       modified:   configure.ac
       modified:   orchagent/Makefile.am
       modified:   orchagent/orchdaemon.cpp
       modified:   orchagent/orchdaemon.h
       modified:   orchagent/port.h
       modified:   orchagent/portsorch.cpp
       modified:   orchagent/saihelper.cpp
       new file:   orchagent/stporch.cpp
       new file:   orchagent/stporch.h
       new file:   swssconfig/sample/00-copp.config.json
       modified:   tests/mock_tests/Makefile.am

Signed-off-by: Balareddy Bendrapu <[email protected]>
@adyeung
Copy link

adyeung commented Sep 12, 2024

@bendrapubalareddy BRCM posted the original PVST code PR to the community back in 2019, what is the point of reposting the same? By 2024, the SONiC community has approved and agreed upon MSTP through the SONiC HLD review meetings and PENS WG. The design and scope of this approved MSTP will encompass the requirements of PVST. Reintroducing the PVST code PR at this juncture risks significant conflicts with the upcoming MSTP contributions from BRCM and xFLOW.

@bendrapubalareddy
Copy link
Author

bendrapubalareddy commented Sep 16, 2024

@bendrapubalareddy BRCM posted the original PVST code PR to the community back in 2019, what is the point of reposting the same? By 2024, the SONiC community has approved and agreed upon MSTP through the SONiC HLD review meetings and PENS WG. The design and scope of this approved MSTP will encompass the requirements of PVST. Reintroducing the PVST code PR at this juncture risks significant conflicts with the upcoming MSTP contributions from BRCM and xFLOW.

Yes, these are old PRs from BRCM for PVST functionality. It needed some fixes to make it work. There should not be conflicts with MSTP if we are aligned with PVST functionality as per these PRs. We can work together to resolve conflicts if there is any. Could you please share the next meeting of MSTP review, we can join and discuss. I thought today there is meeting, but i did not find an invite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants