Update buffermgrdyn.cpp #3435
Open
Update buffermgrdyn.cpp #3435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
The committers listed above are authorized under a signed CLA. |
|
Azure Pipelines successfully started running 1 pipeline(s). |
prsunny
reviewed
Jan 6, 2025
| @@ -325,10 +325,13 @@ void BufferMgrDynamic::loadZeroPoolAndProfiles() | |||
| auto &poolObj = poolSearchRef->second; | |||
| if (poolObj.zero_profile_name.empty()) | |||
| { | |||
| if(poolObj.direction>= 0 && poolObj.direction <= 2) // ensuring the poolpbj.direction will not get out of boundaries | |||
|
@mramezani95 to review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
i added if condetion that will ensure that the poolobj.direction will not size of the string m_bufferZeroProfileName so that the string will not get out of boundaries
Why I did it
as the checkmarx tool was telling this as high severity valunerability in the code
How I verified it
added the if condition and regenerated a repoert and the valunerability disappeared
Details if related
so based on that this will also make it safe in case any one add any value to the enum of the poolobj.direction as it will make safe from being out of boundaries