Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prompt: update powerlevel10k submodule to v1.14.3 #1874

Merged
merged 1 commit into from
Dec 14, 2020
Merged

prompt: update powerlevel10k submodule to v1.14.3 #1874

merged 1 commit into from
Dec 14, 2020

Conversation

romkatv
Copy link
Contributor

@romkatv romkatv commented Nov 26, 2020

@romkatv romkatv changed the title prompt: update powerlevel10k submodule to v1.14.1 prompt: update powerlevel10k submodule to v1.14.2 Nov 26, 2020
@romkatv romkatv changed the title prompt: update powerlevel10k submodule to v1.14.2 prompt: update powerlevel10k submodule to v1.14.3 Nov 26, 2020
@melgu
Copy link

melgu commented Dec 8, 2020

Please merge. It potentially fixes issues on Silicon Macs running Big Sur.

@romkatv
Copy link
Contributor Author

romkatv commented Dec 8, 2020

Please merge. It potentially fixes issues on Silicon Macs running Big Sur.

It does. From release notes:

Support Apple Silicon (Darwin arm64).

@jonBoone
Copy link

Yes, please merge. gitstatus is not working on my Apple Silicon M1 running Big Sur with p10k theme. I really love this theme...

prezto is 👍

@billinghamj
Copy link

@sorin-ionescu @belak Possible this could be looked at this week?

@billinghamj
Copy link

Also maybe @romkatv could be added as a maintainer? Seems a pretty high proportion of the commits these days are p10k being updated - otherwise the project is fairly dormant anyway.

@belak belak merged commit e915c34 into sorin-ionescu:master Dec 14, 2020
@romkatv
Copy link
Contributor Author

romkatv commented Dec 15, 2020

Thanks, @belak !

@belak
Copy link
Collaborator

belak commented Dec 16, 2020

Thanks for the ping - I must have missed this.

@billinghamj This was brought up before, but romkatv respectfully declined. Also, at the moment Sorin is still the only person who has admin access to this repo, so we're dependent on him to add collaborators.

@romkatv
Copy link
Contributor Author

romkatv commented Dec 16, 2020

@billinghamj This was brought up before, but romkatv respectfully declined.

Right. It may look like I'm responsible for a large share of commits to prezto but there is no code in them. All my PRs are one line changes devoid of code. They just move the commit hash for powerlevel10k submodule.

@belak
Copy link
Collaborator

belak commented Dec 16, 2020

Yep, I respect your position. I mostly wanted to have you added so you could make those one-line changes without needing to wait for anyone. My reply was just an unsent one (from two days ago that I found in a tab) aiming to clear up why you haven't been added. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants