This repository has been archived by the owner on Aug 29, 2023. It is now read-only.
chore: transpile modern JS features for older browsers #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aheckmann
previously approved these changes
Jun 23, 2023
* chore: add semantic-release dependency * chore: init semantic release GitHub workflow * fix: bump node version in CI to LTS * chore: add "semantic-release" script to package.json
aheckmann
approved these changes
Jun 24, 2023
|
🎉 This PR is included in version 0.1.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transpile Modern JS features for Older Browsers
Resolves:
Summary
Aims to prevent errors in older browsers related to the use of modern JS/TS features by extending Next.js' default Babel configuration.
Changes
@babel/coreand@babel/preset-envdependencies.babelrcfile@babel/preset-envto target all browsers that eithera. Have more than 0.25% market share
b. Are not "dead" (without official support/updates for > 24 months).
Note
The Next.js docs warn of the following:
However, our
.babelrcdoesn't need any adjustments, because themodulesoption is not explicitly set in the@babel/preset-envconfiguration, which means it will default tofalse, as recommended by the Next.js documentation. 🤓