feat: Aptos Client #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tranduy1dol
force-pushed
the
feat/aptos
branch
2 times, most recently
from
4d0f0e1
to
93a27bd
Compare
0x5ea000000
commented
Sep 5, 2024
Cargo.toml
Outdated
| @@ -17,6 +17,7 @@ members = [ | |||
| "crates/primitives/state_update", | |||
| "crates/primitives/utils", | |||
| "crates/tests", | |||
| "crates/client/aptos", | |||
There was a problem hiding this comment.
rearrange it to near crates/client
0x5ea000000
commented
Sep 5, 2024
| license.workspace = true | ||
|
|
||
| [dependencies] | ||
| alloy = { workspace = true} |
There was a problem hiding this comment.
why we need alloy here? on Aptos?
0x5ea000000
commented
Sep 5, 2024
| l1_block_number: registry | ||
| .register(Gauge::new("deoxys_l1_block_number", "Gauge for deoxys L1 block number")?)?, | ||
|
|
||
| l1_gas_price_wei: registry.register(Gauge::new("deoxys_l1_gas_price", "Gauge for deoxys L1 gas price")?)?, |
There was a problem hiding this comment.
it should be l1_gas_price_octas? (minium unit in Aptos)
0x5ea000000
commented
Sep 5, 2024
| } | ||
| } | ||
|
|
||
| impl AptosClient { |
There was a problem hiding this comment.
maybe we should define trait for swapping out between many types of Client easier
|
@Tranduy1dol we need to add to |
Tranduy1dol
force-pushed
the
feat/aptos
branch
from
9c6c8b8
to
fe4bb74
Compare
zk-steve
force-pushed
the
feat/aptos
branch
2 times, most recently
from
a641c9e
to
ff84fd4
Compare
zk-steve
force-pushed
the
feat/aptos
branch
2 times, most recently
from
3892f0d
to
2739c9c
Compare
Tranduy1dol
force-pushed
the
feat/aptos
branch
2 times, most recently
from
f05ecd9
to
4125ee2
Compare
Tranduy1dol
force-pushed
the
feat/aptos
branch
from
95b45f9
to
00e459a
Compare
Tranduy1dol
force-pushed
the
feat/aptos
branch
from
00e459a
to
25f19ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Please add the labels corresponding to the type of changes your PR introduces:
What is the current behavior?
Resolves: #NA
What is the new behavior?
Does this introduce a breaking change?
Other information