Fix deprecation notice in PHP 8.x #78
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the documentation, all versions of PHP support the `usort` callable parameter returning an `integer`. While earlier versions silently accepted a `boolean`, PHP 8.x throws a deprecation notice: ``` Deprecation Notice: usort(): Returning bool from comparison function is deprecated, return an integer less than, equal to, or greater than zero in C:\Users\MY_USER\AppData\Roaming\Composer\vendor\sllh\composer-versions-check\src\VersionsCheck.php:54 ``` This fix (based on [this comment](soullivaneuh#75 (comment))) eliminates this notice. fixes soullivaneuh#74
Maxooo
approved these changes
Nov 26, 2021
|
Everything looks good ! Does anyone with write access can validate it too ? @soullivaneuh @EmanueleMinotto @dereuromark @TomasVotruba |
vviaudroussel
approved these changes
Sep 23, 2022
|
I dont have write access^^ |
|
Can someone please click on the merge button? |
|
This project is clearly completely dead for years. I created a new fork ( https://github.com/dereuromark/composer-versions-check ). |
jeffersonsimaogoncalves
approved these changes
Jul 5, 2023
jeffersonsimaogoncalves
approved these changes
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the documentation, all versions of PHP support the
usortcallable parameter returning aninteger. While earlier versions silently accepted aboolean, PHP 8.x throws a deprecation notice:This fix (based on this comment) eliminates this notice.
fixes #74