Soulomoon/refactor session #134
Annotations
15 warnings
|
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, rwe/actions-hlint-setup@v1, rwe/actions-hlint-run@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
The following actions uses node12 which is deprecated and will be forced to run on node16: rwe/actions-hlint-setup@v1, rwe/actions-hlint-run@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Checking code:
exe/Wrapper.hs#L1
Warning in module Main: Use module export list ▫︎ Found: "module Main where" ▫︎ Perhaps: "module Main (\n module Main\n ) where" ▫︎ Note: an explicit list is usually better
|
|
Checking code:
ghcide/session-loader/Development/IDE/Session.hs#L112
Warning in module Development.IDE.Session: Use fewer imports ▫︎ Found: "import Development.IDE ( Rules, getFileExists )\nimport Development.IDE ( RuleResult )\n" ▫︎ Perhaps: "import Development.IDE ( Rules, getFileExists, RuleResult )\n"
|
|
Checking code:
ghcide/session-loader/Development/IDE/Session.hs#L123
Suggestion in module Development.IDE.Session: Redundant as ▫︎ Found: "import qualified UnliftIO as UnliftIO" ▫︎ Perhaps: "import qualified UnliftIO"
|
|
Checking code:
ghcide/session-loader/Development/IDE/Session.hs#L496
Suggestion in loadSessionWithOptions in module Development.IDE.Session: Use const ▫︎ Found: "\\ _ -> Map.empty" ▫︎ Perhaps: "const Map.empty"
|
|
Checking code:
ghcide/session-loader/Development/IDE/Session.hs#L498
Suggestion in loadSessionWithOptions in module Development.IDE.Session: Use const ▫︎ Found: "\\ _ -> Map.empty" ▫︎ Perhaps: "const Map.empty"
|
|
Checking code:
ghcide/session-loader/Development/IDE/Session.hs#L499
Suggestion in loadSessionWithOptions in module Development.IDE.Session: Use const ▫︎ Found: "\\ _ -> HM.empty" ▫︎ Perhaps: "const HM.empty"
|
|
Checking code:
ghcide/session-loader/Development/IDE/Session.hs#L571
Suggestion in loadSessionWithOptions in module Development.IDE.Session: Redundant $ ▫︎ Found: "return $ (x, Map.keys y, cfps', [keys1, keys2])" ▫︎ Perhaps: "return (x, Map.keys y, cfps', [keys1, keys2])"
|
|
Checking code:
ghcide/session-loader/Development/IDE/Session.hs#L715
Warning in loadSessionWithOptions in module Development.IDE.Session: Use atomicModifyIORef'_ ▫︎ Found: "atomicModifyIORef'\n cradle_files (\\ xs -> (fromNormalizedFilePath cfp : xs, ()))" ▫︎ Perhaps: "atomicModifyIORef'_ cradle_files ((:) (fromNormalizedFilePath cfp))"
|
|
Checking code:
ghcide/session-loader/Development/IDE/Session.hs#L814
Warning in loadSessionWithOptions in module Development.IDE.Session: Using fmap on tuple ▫︎ Found: "(fmap . fmap) toAbsolutePath (a, b)" ▫︎ Perhaps: "(a, fmap toAbsolutePath b)"
|
|
Checking code:
ghcide/session-loader/Development/IDE/Session/Diagnostics.hs#L1
Warning in module Development.IDE.Session.Diagnostics: Use module export list ▫︎ Found: "module Development.IDE.Session.Diagnostics where" ▫︎ Perhaps: "module Development.IDE.Session.Diagnostics (\n module Development.IDE.Session.Diagnostics\n ) where" ▫︎ Note: an explicit list is usually better
|
|
Installing
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Installing
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Installing
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Loading