Skip to content

Soulomoon/refactor session #145

Soulomoon/refactor session

Soulomoon/refactor session #145

Triggered via pull request May 24, 2024 06:30
Status Success
Total duration 46s
Artifacts

hlint.yml

on: pull_request
Hlint check run
38s
Hlint check run
Fit to window
Zoom out
Zoom in

Annotations

15 warnings
Hlint check run
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, rwe/actions-hlint-setup@v1, rwe/actions-hlint-run@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Hlint check run
The following actions uses node12 which is deprecated and will be forced to run on node16: rwe/actions-hlint-setup@v1, rwe/actions-hlint-run@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Hlint check run: exe/Wrapper.hs#L1
Warning in module Main: Use module export list ▫︎ Found: "module Main where" ▫︎ Perhaps: "module Main (\n module Main\n ) where" ▫︎ Note: an explicit list is usually better
Hlint check run: ghcide/session-loader/Development/IDE/Session.hs#L128
Suggestion in module Development.IDE.Session: Redundant as ▫︎ Found: "import qualified UnliftIO as UnliftIO" ▫︎ Perhaps: "import qualified UnliftIO"
Hlint check run: ghcide/session-loader/Development/IDE/Session.hs#L496
Suggestion in loadSessionWithOptions in module Development.IDE.Session: Use const ▫︎ Found: "\\ _ -> Map.empty" ▫︎ Perhaps: "const Map.empty"
Hlint check run: ghcide/session-loader/Development/IDE/Session.hs#L497
Suggestion in loadSessionWithOptions in module Development.IDE.Session: Use const ▫︎ Found: "\\ _ -> Map.empty" ▫︎ Perhaps: "const Map.empty"
Hlint check run: ghcide/session-loader/Development/IDE/Session.hs#L498
Suggestion in loadSessionWithOptions in module Development.IDE.Session: Use const ▫︎ Found: "\\ _ -> HM.empty" ▫︎ Perhaps: "const HM.empty"
Hlint check run: ghcide/session-loader/Development/IDE/Session.hs#L592
Suggestion in loadSessionWithOptions in module Development.IDE.Session: Redundant $ ▫︎ Found: "liftIO $ getCacheDirsRoot" ▫︎ Perhaps: "liftIO getCacheDirsRoot"
Hlint check run: ghcide/session-loader/Development/IDE/Session.hs#L719
Suggestion in loadSessionWithOptions in module Development.IDE.Session: Redundant $ ▫︎ Found: "const\n $ (do liftIO\n $ atomicModifyIORef'\n cradle_files (\\ xs -> (fromNormalizedFilePath cfp : xs, ()))\n result@(_, _, files, keys) <- session (hieYaml, cfp, opts, libDir)\n liftIO\n $ when (notNull files || notNull keys)\n $ do checkProject <- getCheckProject\n restartShakeSession\n VFSUnmodified \"new component\"\n (if checkProject then return (typecheckAll files) else mempty)\n (pure keys)\n return result)" ▫︎ Perhaps: "const\n (do liftIO\n $ atomicModifyIORef'\n cradle_files (\\ xs -> (fromNormalizedFilePath cfp : xs, ()))\n result@(_, _, files, keys) <- session (hieYaml, cfp, opts, libDir)\n liftIO\n $ when (notNull files || notNull keys)\n $ do checkProject <- getCheckProject\n restartShakeSession\n VFSUnmodified \"new component\"\n (if checkProject then return (typecheckAll files) else mempty)\n (pure keys)\n return result)"
Hlint check run: ghcide/session-loader/Development/IDE/Session.hs#L720
Warning in loadSessionWithOptions in module Development.IDE.Session: Use atomicModifyIORef'_ ▫︎ Found: "atomicModifyIORef'\n cradle_files (\\ xs -> (fromNormalizedFilePath cfp : xs, ()))" ▫︎ Perhaps: "atomicModifyIORef'_ cradle_files ((:) (fromNormalizedFilePath cfp))"
Hlint check run: ghcide/session-loader/Development/IDE/Session.hs#L820
Suggestion in loadSessionWithOptions in module Development.IDE.Session: Redundant bracket ▫︎ Found: "do _opts@(a, b, _files, _keys) <- (hieYamlRuleImpl file)\n pure (a, fmap toAbsolutePath b)" ▫︎ Perhaps: "do _opts@(a, b, _files, _keys) <- hieYamlRuleImpl file\n pure (a, fmap toAbsolutePath b)"
Hlint check run: ghcide/session-loader/Development/IDE/Session/Diagnostics.hs#L1
Warning in module Development.IDE.Session.Diagnostics: Use module export list ▫︎ Found: "module Development.IDE.Session.Diagnostics where" ▫︎ Perhaps: "module Development.IDE.Session.Diagnostics (\n module Development.IDE.Session.Diagnostics\n ) where" ▫︎ Note: an explicit list is usually better
Hlint check run
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Hlint check run
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Hlint check run
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/