WIP: general upgrade and RootShell library instead of jar? #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
October 2, 2018 07:21
compileSdk and targetSdk to 28. Like this, modern versions of Android Studio don't cry as much :)
importing jar. This should make the app F-Droid compliant and solve #5. Also see: https://gitlab.com/fdroid/rfp/issues/92 Warning: the code is not yet compatible with the new RootShell API!
- override outputCommand(id, line) and not output(id, line) as it is now a protected method and the documentation says to do this like this. See: - call super.outputCommand(id, line) from every overriden outputCommand as documented: See: https://github.com/Stericson/RootShell/wiki/Usage#running-root-commands
CommandCapture doesn't exist anymore but as far as I can see, it just used to log the output with RootTools.log. Implement this in overriden commandOutput methods like RootTools used to do it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades gradle tools and dependencies.
Also uses RootShell as jitpack.io library, making it F-Droid compatible, as far as I can tell.
You can build an apk with the latest Android Studio. And that's basically it. On my device it crashes immediately. But so did latest release apk too (which was the reason for me to try to build it in the first place).
I think the CommandCapture changes are correct, but maybe you could take a look at those 😄
Just let me know if you'd like me to change something.
Cheers,
Juanito