fix(authentication-service): added idp server controller for login and discovery endpoint #2131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I can not see all the endpoints mentioned here, https://docs.google.com/document/d/1r2v55eC5dbGBsA5ka_JQnzIIO80hdTqA6p8qCRKQmqU/edit
Also please specify and work on key rotation
prernagp
force-pushed
the
issue-2034
branch
4 times, most recently
from
8aafdb7
to
b5303d9
Compare
samarpan-b
reviewed
Aug 6, 2024
| @@ -25,6 +25,7 @@ | |||
| } | |||
| }, | |||
| "scripts": { | |||
| "start": "node -r source-map-support/register .", | |||
samarpan-b
reviewed
Aug 7, 2024
| }) | ||
| req: RefreshTokenRequest, | ||
| ): Promise<SuccessResponse> { | ||
| const token = auth?.replace(/bearer /i, ''); |
There was a problem hiding this comment.
Cant we reuse existing code ?
prernagp
force-pushed
the
issue-2034
branch
2 times, most recently
from
c66c5ac
to
f1ed738
Compare
|
prernagp
force-pushed
the
issue-2034
branch
3 times, most recently
from
c0b90f6
to
733baea
Compare
prernagp
force-pushed
the
issue-2034
branch
2 times, most recently
from
ee0c517
to
aa344d6
Compare
…d discovery endpoint BREAKING CHANGE:
prernagp
force-pushed
the
issue-2034
branch
3 times, most recently
from
ffcf860
to
ff1489e
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added IDP server controller for login and discovery endpoint
Fixes # (issue) #2034
Type of change
Please delete options that are not relevant.
Checklist: