Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): createdon modifiedon can not be changed via input #2159

Merged
merged 3 commits into from
Sep 24, 2024

Conversation

yeshamavani
Copy link
Contributor

gh-2158

Description

createdon modifiedon can not be changed via input
even if its passed in the input we will delete the fields and update it from db

Fixes #2158

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Intermediate change (work in progress)

Checklist:

  • Performed a self-review of my own code
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Any dependent changes have been merged and published in downstream modules

@yeshamavani yeshamavani requested a review from a team as a code owner August 30, 2024 10:51
Copy link

sonarcloud bot commented Aug 30, 2024

@yeshamavani yeshamavani merged commit 411dd76 into master Sep 24, 2024
5 checks passed
@yeshamavani yeshamavani deleted the GH-2158 branch September 24, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@sourceloop/core: CreatedOn and ModifiedOn columns should not be data driven
2 participants