-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
demonstration: sg ops update produces nasty formatting diffs / doesn't work as expected #4207
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Stephen Gutekanst <[email protected]>
This appears to produce the least intrusive diff (still formatting in some files, but not too bad):
|
Produced via: ``` sg ops update-images -t 187572_2022-12-06_cbecc5321c7d -kind k8s ./base git checkout -- **/*.ConfigMap.yaml **/*.Role.yaml **/*.Ingress.yaml **/*.Service.yaml **/*.IndexerService.yaml git add base/ ``` See also #4207 Signed-off-by: Stephen Gutekanst <[email protected]>
Another complaint/observation:
|
* all: replace minio with sourcegraph/blobstore * all: update image tags Produced via: ``` sg ops update-images -t 187572_2022-12-06_cbecc5321c7d -kind k8s ./base git checkout -- **/*.ConfigMap.yaml **/*.Role.yaml **/*.Ingress.yaml **/*.Service.yaml **/*.IndexerService.yaml git add base/ ``` See also #4207 Signed-off-by: Stephen Gutekanst <[email protected]>
* all: replace minio with sourcegraph/blobstore * all: update image tags Produced via: ``` sg ops update-images -t 187572_2022-12-06_cbecc5321c7d -kind k8s ./base git checkout -- **/*.ConfigMap.yaml **/*.Role.yaml **/*.Ingress.yaml **/*.Service.yaml **/*.IndexerService.yaml git add base/ ``` See also #4207 Signed-off-by: Stephen Gutekanst <[email protected]>
* all: replace minio with sourcegraph/blobstore (#4206) * all: replace minio with sourcegraph/blobstore * all: update image tags Produced via: ``` sg ops update-images -t 187572_2022-12-06_cbecc5321c7d -kind k8s ./base git checkout -- **/*.ConfigMap.yaml **/*.Role.yaml **/*.Ingress.yaml **/*.Service.yaml **/*.IndexerService.yaml git add base/ ``` See also #4207 Signed-off-by: Stephen Gutekanst <[email protected]> * all: update image tags to :4.2_187939_2022-12-07_5d744edd0103 Produced via: ``` sg ops update-images -t 4.2_187939_2022-12-07_5d744edd0103 -kind k8s ./base git checkout -- **/*.ConfigMap.yaml **/*.Role.yaml **/*.Ingress.yaml **/*.Service.yaml **/*.IndexerService.yaml git add base/ ``` Signed-off-by: Stephen Gutekanst <[email protected]> Signed-off-by: Stephen Gutekanst <[email protected]>
DO NOT MERGE
This is a demonstration that
sg ops update
doesn't really work today.This change was produced via:
Most changes here are innocuous, but a few formatting changes here are quite aggressive:
base/prometheus/prometheus.ConfigMap.yaml