Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update images lib #4299

Merged
merged 2 commits into from
Feb 23, 2024
Merged

update images lib #4299

merged 2 commits into from
Feb 23, 2024

Conversation

BolajiOlajide
Copy link
Contributor

Description

NOTE:

Checklist

Test plan

Update images lib

Release should work fine!

@BolajiOlajide BolajiOlajide requested a review from a team February 23, 2024 12:23
@BolajiOlajide BolajiOlajide self-assigned this Feb 23, 2024
keegancsmith
keegancsmith approved these changes Feb 23, 2024
View reviewed changes
Copy link
Member

@keegancsmith keegancsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe run go mod tidy?

@BolajiOlajide
Copy link
Contributor Author

maybe run go mod tidy?

THanks for the nudge. I actually did but hadn't noticed that failed on my terminal - needed to install some deps used in the tests.

@BolajiOlajide BolajiOlajide merged commit 5e2c382 into 5.3 Feb 23, 2024
4 of 5 checks passed
@BolajiOlajide BolajiOlajide deleted the bo/update-images-lib-5.3 branch February 23, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keegancsmith keegancsmith keegancsmith approved these changes

Assignees

@BolajiOlajide BolajiOlajide

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BolajiOlajide @keegancsmith